Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp772417pxj; Fri, 14 May 2021 15:53:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjDkzlY2E3p6z55iHAJ36dCB2dmGfZXWsIymmpYE8KAACxyen1p/reWBj3npsesxKz/i1A X-Received: by 2002:a92:d212:: with SMTP id y18mr10942907ily.176.1621032837884; Fri, 14 May 2021 15:53:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621032837; cv=none; d=google.com; s=arc-20160816; b=SBCP/M/AeqOWpzRskNA3jqHA2rgjwU4DBxZpDCBRhfP6AzvWOGGliEq8DjaG6pPAbf NmljhmJ4lZvFMX0bwc9o8GqYhOEGZX/rvtKNSBW1xJdssdgGELUa0s8jk/qBqwGoYy1d WpvzREGPb/ykHUG1lBjk2vjUOKKYyHUbUkfF41ZI6CwylhyukHCgf3qmVJ3BFt3/EOvC qKru838hnoqVYtNg2IpxiarnKrbaVnefRg7ezVcuSpw50iQtgZgaFeuAb636iXP7H1aV bilauaIoa0Ce+kd0I8nvMSemTQcJCmq36U8feRDrLmi6OE7e5vD4wWolXBTl75T3yfnc Ktiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6WPvib1+u/MMJIgAB5EE+Z8wqS5Q6D/ao0Rp9ErE8YA=; b=efUEHB27oUe73RNiaOOZCEiNAQUjJNrF3JU2CR00DBohnfXwoB03g/KCh2TXQxkvLT q3hEyeeqc6rGIGV3X4zlnuB6+xaKjfIvBf7pGwDISZYz/K/7D2Jm71cUMNLFT837ruHW IyeMNRWnnEQvlCOTp9LbSRjSpWYk8oPBrsQpzzu/eBYx99chB4lXlwU7vFh3kxvpn2DP ntnQrPdwsc7TZjam9ic/Ze0+l43Gw3VsZ24NYJUlXax67fSCrXxVoXHJ/YUZ9cfl0OC7 aA/4Vm4EWpxY8/bGHvvsXuZif4i4JydmwUdjNufAsBJuEwx9tHb77AijQn5gtaz8tOe5 LR8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ysoft.com header.s=20160406-ysoft-com header.b=eSy1gTqN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=ysoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j9si10153251jak.0.2021.05.14.15.53.45; Fri, 14 May 2021 15:53:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ysoft.com header.s=20160406-ysoft-com header.b=eSy1gTqN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=ysoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234573AbhENOqy (ORCPT + 99 others); Fri, 14 May 2021 10:46:54 -0400 Received: from uho.ysoft.cz ([81.19.3.130]:49105 "EHLO uho.ysoft.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232759AbhENOqv (ORCPT ); Fri, 14 May 2021 10:46:51 -0400 Received: from vokac-latitude.ysoft.local (unknown [10.0.28.99]) by uho.ysoft.cz (Postfix) with ESMTP id 0FF8AA2C5C; Fri, 14 May 2021 16:45:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1621003538; bh=6WPvib1+u/MMJIgAB5EE+Z8wqS5Q6D/ao0Rp9ErE8YA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eSy1gTqN3ciGBYEgRG6f1yTI2yMrEx8pCZBaWsgMuzE7ZeBIWS7bYLboNd2vBD2Pt L1tZdFrFZ7me83LZA2b+6Z8JOaZlrl7YKuLaQE1ODuIwISBLwgOUQetz/yBCRD9WmQ +c/nwRhJucJ8c4gxomv31ieBI4ga5pkOHZ2W0j9Q= From: =?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?= To: Pavel Machek , Jacek Anaszewski , Rob Herring , Shawn Guo Cc: Fabio Estevam , devicetree@vger.kernel.org, Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, =?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?= , stable@vger.kernel.org Subject: [RFC 2/2] ARM: dts: imx6dl-yapp4: Fix lp5562 driver probe Date: Fri, 14 May 2021 16:44:37 +0200 Message-Id: <1621003477-11250-3-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1621003477-11250-1-git-send-email-michal.vokac@ysoft.com> References: <1621003477-11250-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the LED multicolor framework support was added in commit 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") LEDs on this platform stopped working. Author of the framework attempted to accommodate this DT to the framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node") but that is not sufficient. A color property is now required even if the multicolor framework is not used, otherwise the driver probe fails: lp5562: probe of 1-0030 failed with error -22 Add the color property to fix this and remove the actually unused white channel. Fixes: b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node") Cc: Cc: Pavel Machek Cc: Jacek Anaszewski Cc: linux-leds@vger.kernel.org Signed-off-by: Michal Vokáč --- arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi index 7d2c72562c73..3107bf7fbce5 100644 --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi @@ -5,6 +5,7 @@ #include #include #include +#include #include / { @@ -271,6 +272,7 @@ led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; reg = <0>; + color = ; }; chan@1 { @@ -278,6 +280,7 @@ led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; reg = <1>; + color = ; }; chan@2 { @@ -285,13 +288,7 @@ led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; reg = <2>; - }; - - chan@3 { - chan-name = "W"; - led-cur = /bits/ 8 <0x0>; - max-cur = /bits/ 8 <0x0>; - reg = <3>; + color = ; }; }; -- 2.7.4