Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210514072228.534418-1-glider@google.com>
In-Reply-To: <20210514072228.534418-1-glider@google.com>
From:   Alexander Potapenko <glider@google.com>
Date:   Fri, 14 May 2021 18:29:18 +0200
Message-ID: <CAG_fn=UUbex_=Tao8g2Pcz2A7ZrhnOvEnV=8HCR5myWP5eL+AQ@mail.gmail.com>
Subject: Re: [PATCH] kasan: slab: always reset the tag in get_freepointer_safe()
To:     akpm@linux-foundation.org,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>
Cc:     Marco Elver <elver@google.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Elliot Berman <eberman@codeaurora.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, May 14, 2021 at 9:22 AM Alexander Potapenko <glider@google.com> wro=
te:
>
> With CONFIG_DEBUG_PAGEALLOC enabled, the kernel should also untag the
> object pointer, as done in get_freepointer().
>
> Failing to do so reportedly leads to SLUB freelist corruptions that
> manifest as boot-time crashes.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Marco Elver <elver@google.com>
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Cc: Andrey Konovalov <andreyknvl@gmail.com>
> Cc: Elliot Berman <eberman@codeaurora.org>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Alexander Potapenko <glider@google.com>
> ---
>  mm/slub.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index feda53ae62ba..9a4f59e5b0c2 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -301,6 +301,7 @@ static inline void *get_freepointer_safe(struct kmem_=
cache *s, void *object)
>         if (!debug_pagealloc_enabled_static())
>                 return get_freepointer(s, object);
>
> +       object =3D kasan_reset_tag(object);
>         freepointer_addr =3D (unsigned long)object + s->offset;
>         copy_from_kernel_nofault(&p, (void **)freepointer_addr, sizeof(p)=
);
>         return freelist_ptr(s, p, freepointer_addr);
> --
> 2.31.1.751.gd2f1c929bd-goog
>


--=20
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe, 33
80636 M=C3=BCnchen

Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg