Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <7cc30a8a6644bb60e5f3358e89253d9fc783fe54.camel@perches.com>
Subject: Re: [PATCH 2/2] x86/e820: Use pr_debug to avoid spamming dmesg log
 with debug messages
From:   Joe Perches <joe@perches.com>
To:     Jason Baron <jbaron@akamai.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date:   Fri, 14 May 2021 10:38:58 -0700
In-Reply-To: <5a416031-ddcd-7ef4-ec33-47134bf064bb@akamai.com>
References: <f527618e-54f2-c2fb-e267-8065ac34e462@gmail.com>
         <6d55670d-2f06-d768-699f-5a79cece6ce0@gmail.com>
         <d181b674-66fb-1719-e3c6-e4217cf5519c@akamai.com>
         <59985635-665b-773f-de8f-b15fe3f60196@gmail.com>
         <1789b1da-7a0f-9fc9-6ed2-ff68e2306342@akamai.com>
         <204a99e1-de7a-4434-0932-45f1b507e9ec@gmail.com>
         <5a416031-ddcd-7ef4-ec33-47134bf064bb@akamai.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2021-05-11 at 17:31 -0400, Jason Baron wrote:

> That said, I do see the value in not having to open code the branch stuff, and
> making pr_debug() consistent with printk which does return a value. So that
> makes sense to me.

IMO: printk should not return a value.