Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] samples/kprobes: Fix typo in handler_post()
To:     Joe Perches <joe@perches.com>, Jonathan Corbet <corbet@lwn.net>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Marc Koderer <marc@koderer.com>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Johannes Thumshirn <jthumshirn@suse.de>,
        Heiko Carstens <hca@linux.ibm.com>,
        Jisheng Zhang <jszhang@kernel.org>
References: <1620979810-12779-1-git-send-email-yangtiezhu@loongson.cn>
 <cdf1a6fd7d1cbdd19e1c50b280e95b10a9114f6d.camel@perches.com>
Cc:     linux-kernel@vger.kernel.org
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <574a6962-c4c2-9595-16e9-a1e395b83852@loongson.cn>
Date:   Sat, 15 May 2021 09:29:51 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <cdf1a6fd7d1cbdd19e1c50b280e95b10a9114f6d.camel@perches.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05/14/2021 11:26 PM, Joe Perches wrote:
> On Fri, 2021-05-14 at 16:10 +0800, Tiezhu Yang wrote:
>> It should use post_handler instead of pre_handler in handler_post().
>>
>> Fixes: e16c5dd5157e ("samples/kprobes: Add s390 case in kprobe example module")
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>>
>> v2: rebase on the latest mainline kernel
>>
>>   samples/kprobes/kprobe_example.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
>> index c495664..602db3f 100644
>> --- a/samples/kprobes/kprobe_example.c
>> +++ b/samples/kprobes/kprobe_example.c
>> @@ -89,7 +89,7 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs,
>>   		p->symbol_name, p->addr, regs->status);
>>   #endif
>>   #ifdef CONFIG_S390
>> -	pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n",
>> +	pr_info("<%s> post_handler: p->addr, 0x%p, flags = 0x%lx\n",
>>   		p->symbol_name, p->addr, regs->flags);
>>   #endif
>>   }
> Perhaps better would be to use pr_fmt and remove all the
> embedded pre/post strings.
>
> This would change the style of the output through.
>
> Also fix a defective format in handler_fault ending with
> an 'n' that should be '\n'

Thank you, it looks better, let me send v3 as you suggested.

[...]