Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423588AbWJZPxh (ORCPT ); Thu, 26 Oct 2006 11:53:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423586AbWJZPxh (ORCPT ); Thu, 26 Oct 2006 11:53:37 -0400 Received: from agminet01.oracle.com ([141.146.126.228]:9576 "EHLO agminet01.oracle.com") by vger.kernel.org with ESMTP id S1423464AbWJZPxg (ORCPT ); Thu, 26 Oct 2006 11:53:36 -0400 Message-ID: <4540D96D.601@oracle.com> Date: Thu, 26 Oct 2006 08:51:09 -0700 From: "Randy.Dunlap" User-Agent: Thunderbird 1.5.0.5 (X11/20060719) MIME-Version: 1.0 To: Adrian Bunk CC: David Brownell , toralf.foerster@gmx.de, netdev@vger.kernel.org, linux-usb-devel@lists.sourceforge.net, link@miggy.org, greg@kroah.com, akpm@osdl.org, zippel@linux-m68k.org, torvalds@osdl.org, linux-kernel@vger.kernel.org, dbrownell@users.sourceforge.net, Arnd Bergmann Subject: Re: [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled References: <20061025201341.GH21200@miggy.org> <20061025151737.1bf4898c.randy.dunlap@oracle.com> <20061025222709.A13681C5E0B@adsl-69-226-248-13.dsl.pltn13.pacbell.net> <20061025165858.b76b4fd8.randy.dunlap@oracle.com> <20061026154635.GK27968@stusta.de> In-Reply-To: <20061026154635.GK27968@stusta.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1092 Lines: 35 Adrian Bunk wrote: > On Wed, Oct 25, 2006 at 04:58:58PM -0700, Randy Dunlap wrote: >> ... >> Build tested with CONFIG_MII=y, m, n. >> ... >> --- linux-2619-rc3-pv.orig/drivers/usb/net/usbnet.c >> +++ linux-2619-rc3-pv/drivers/usb/net/usbnet.c >> @@ -47,6 +47,12 @@ >> >> #define DRIVER_VERSION "22-Aug-2005" >> >> +#if defined(CONFIG_MII) || defined(CONFIG_MII_MODULE) >> +#define HAVE_MII 1 >> +#else >> +#define HAVE_MII 0 >> +#endif >> ... > > I'm too lame to test it, but I bet this will break with > CONFIG_USB_USBNET=y, CONFIG_MII=m, and you'll actually need > > #if defined(CONFIG_MII) || (defined(CONFIG_MII_MODULE) && defined(MODULE)) > > And then there's the question whether this amount of #ifdef's is > actually worth avoiding the "select MII"... Thanks, but that's OK, David posted a different patch for it. -- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/