Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1098270pxj; Sat, 15 May 2021 03:56:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtNitlo7yBKymCjMEm/m9m0/zrzsVZGluXFyUwcgB3EI94Rl8IPE4DUC7KjJy1isc4mj+4 X-Received: by 2002:a92:3610:: with SMTP id d16mr3150118ila.16.1621076183206; Sat, 15 May 2021 03:56:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621076183; cv=none; d=google.com; s=arc-20160816; b=NOlx4fspQQKb56+dodu5qredcKYLs6Zp6RlKBhFP2VVP99kHS/9V8+hAF2Gbly2tPa NLJc+DxJr+imlurO4k5z/2ZcQcXj0jMIMY9Y0Y3KsNhdFhT7S7YIGohdIj4wfsXC8FW/ hg+jhRnyXGBj68J52ZHASCoJMkN3Rtp8QRyhSb6gppC0QlDQcTo0RWU9rr9P5CbMI9pO 5fXJ5vUpru+KT34YCkdIkQtiwNyJzzO4HxWtY30eJ6HKNbKdzVSaUbTP/cS97LDelkyp u6NI/lWvJ4eJKSK9JJ0EkZiah+liuXO6dBRzFESZ8wB5uTnC55mP5sjh6gdsoPWZ+y0k aflQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=XFsEIFdynORN4FqqNCKpnVM8YQFE5KakxCgG98ZK27Y=; b=Sb+s9+5NfjUYKJFkXZiJrXFfCUuHM02XaBrXU1q0HgmSspih850BmKIQG4BvrTYavk Lu1i8Uwh0DukZzdEu6gzLUzBLhnBc9uARA6/DPhA2KYRY9HFmP3H68avGCDRzKC33Zuy UtvPSvLkCZIEfm49W//K/eFOJCsWxXuePbtUtoxCVhoXFCcZQsgmYFAxDuLsTcnNOF56 ZGodi1fpbTgO2zzNFHELaZ+H6p49O+AsK9a5borBdbJnid8YPPtUjcwPlhA6sp3NHXYs FXI2JX/v6wviPJe0Rt9JLsO5MSBTAw9rMqt4TXxxr9E9SS0bZhbHMQ7eEiV4T/0b3aO1 SvLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h11si10365277ila.129.2021.05.15.03.56.10; Sat, 15 May 2021 03:56:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233974AbhENWbb (ORCPT + 99 others); Fri, 14 May 2021 18:31:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:53582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233967AbhENWb2 (ORCPT ); Fri, 14 May 2021 18:31:28 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D1A561454; Fri, 14 May 2021 22:30:16 +0000 (UTC) Date: Fri, 14 May 2021 18:30:14 -0400 From: Steven Rostedt To: brookxu , Andrew Morton Cc: mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] trace: replace WB_REASON_FOREIGN_FLUSH with a string Message-ID: <20210514183014.592d4567@gandalf.local.home> In-Reply-To: <1619914347-21904-1-git-send-email-brookxu.cn@gmail.com> References: <1619914347-21904-1-git-send-email-brookxu.cn@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew, Would you like to take this? -- Steve On Sun, 2 May 2021 08:12:27 +0800 brookxu wrote: > From: Chunguang Xu > > Now WB_REASON_FOREIGN_FLUSH is displayed as a number, maybe a > string is better. > > v2: replace some space with tab. > > Signed-off-by: Chunguang Xu > --- > include/trace/events/writeback.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h > index 1efa463..7c78c04 100644 > --- a/include/trace/events/writeback.h > +++ b/include/trace/events/writeback.h > @@ -36,7 +36,8 @@ > EM( WB_REASON_PERIODIC, "periodic") \ > EM( WB_REASON_LAPTOP_TIMER, "laptop_timer") \ > EM( WB_REASON_FS_FREE_SPACE, "fs_free_space") \ > - EMe(WB_REASON_FORKER_THREAD, "forker_thread") > + EM( WB_REASON_FORKER_THREAD, "forker_thread") \ > + EMe(WB_REASON_FOREIGN_FLUSH, "foreign_flush") > > WB_WORK_REASON >