Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <68e897fec0e6258b2a964908af650d8608189454.camel@perches.com>
Subject: Re: [PATCH] checkpatch: Print some info if no filenames are given
From:   Joe Perches <joe@perches.com>
To:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Andy Whitcroft <apw@canonical.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     linux-kernel@vger.kernel.org
Date:   Fri, 14 May 2021 21:26:05 -0700
In-Reply-To: <1621052131-16309-1-git-send-email-yangtiezhu@loongson.cn>
References: <1621052131-16309-1-git-send-email-yangtiezhu@loongson.cn>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sat, 2021-05-15 at 12:15 +0800, Tiezhu Yang wrote:
> After commit 45107ff6d526 ("checkpatch: if no filenames then read stdin"),
> if no filenames are given, it will read patch from stdin rather than exit
> directly, it is better to print some info about what to do next, otherwise
> it is a bit confusing whether the script hangs.

I think this is unnecessary.
It's like trying to make cat without command line arguments emit something.

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -361,6 +361,8 @@ if ($^V && $^V lt $minimum_perl_version) {
> ?
> 
> ?#if no filenames are given, push '-' to read patch from stdin
> ?if ($#ARGV < 0) {
> +	print "$P: missing patchfile or -f file\n";
> +	print "Use --help if necessary or read patch from stdin\n";
> ?	push(@ARGV, '-');
> ?}
> ?
>