Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1104204pxj; Sat, 15 May 2021 04:06:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyM+z5GSHMxg+2NkKi6VmIn98XgrOz4aTGoDdExVACD1v9volX9vaKETviQwvQ0bnl0gchh X-Received: by 2002:a92:520a:: with SMTP id g10mr6102257ilb.108.1621076768651; Sat, 15 May 2021 04:06:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621076768; cv=none; d=google.com; s=arc-20160816; b=KHoiKt9+OSh+tcXHurYetR0iDfGL7e65v6ZKi49RE0ZNnavuaC4vff4SbE0+6KRmkN JqdECacPMmlJCFOysNDJ5vZIEl2cCkkT1EnWhqjmS68q1YDvjS7f/WMRvCwJ0U6flPMe hLbTDPBL0lJhnui2mjjkxWxb3aPOqDJKkB7izbYNT8yIzbbtmju7tYNR7dT4wOxKdmNs Nul05W7Zz3/sy8S6atnCV7VR5VZvL6+EfVJTQuNKHdLYGDZ4gksMJnPFbZ7JTITXj0qJ B6sT4hum4Qq6Tmvmha3Iq1UVXzQMchwy4hWcqXV3G+WsNpPVxtbmsEDxn7TQr83nHwzJ yDTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=63rh23KbRch8Sq7hyHOIL/dGUi5ocOJi955zej8YUMs=; b=RCxyGcbdO91dUiU0zeGKSjYUbgfNU8G82ULtdI7K6GbQ4HZ6nNU26cGXjeV2N6epXc Xx7KHVjFWjKPplCm8zrEp5vyihPJVGfUrikLdkiw24CDQoP2OfNCF2HORjUGRLbzmQZy A6xyW9v1hS07pHrox34dlEj1BR81BcKgAJM122CmUXK9+txKAi+JJor9aBIAEcYqaVWw k6i8N7Ko2kieKGXqfuI6+AoQ9bITAn0+PvwK/DsLn+pLuRgCDDLakttq6j2DNAfqIaTD CuXcLVPlQtXP/PLI3REOcFReeATJapX+TD4pWEzW2mM3CDA/gD2v0O1e/tuR/OF8l2Mt VD4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m1si11587038ilu.13.2021.05.15.04.05.56; Sat, 15 May 2021 04:06:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231145AbhEOG3q (ORCPT + 99 others); Sat, 15 May 2021 02:29:46 -0400 Received: from pegase2.c-s.fr ([93.17.235.10]:39263 "EHLO pegase2.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229980AbhEOG3o (ORCPT ); Sat, 15 May 2021 02:29:44 -0400 Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4FhwSs2YMvz9sbb; Sat, 15 May 2021 08:28:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zEapEaUkxjZf; Sat, 15 May 2021 08:28:29 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4FhwSs1YWcz9sbT; Sat, 15 May 2021 08:28:29 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 1A8538B76E; Sat, 15 May 2021 08:28:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id TQ3BUIWyNMAO; Sat, 15 May 2021 08:28:29 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 5554B8B765; Sat, 15 May 2021 08:28:28 +0200 (CEST) Subject: Re: [PATCH] arm64: Define only {pud/pmd}_{set/clear}_huge when usefull To: Andrew Morton Cc: Nicholas Piggin , Mike Kravetz , Mike Rapoport , naresh.kamboju@linaro.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org, linux-mm@kvack.org References: <73ec95f40cafbbb69bdfb43a7f53876fd845b0ce.1620990479.git.christophe.leroy@csgroup.eu> <20210514144200.b49ee77c9b2a7f9998ffbf22@linux-foundation.org> From: Christophe Leroy Message-ID: Date: Sat, 15 May 2021 08:28:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210514144200.b49ee77c9b2a7f9998ffbf22@linux-foundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 14/05/2021 à 23:42, Andrew Morton a écrit : > On Fri, 14 May 2021 11:08:53 +0000 (UTC) Christophe Leroy wrote: > >> When PUD and/or PMD are folded, those functions are useless >> and we now have a stub in linux/pgtable.h > > OK, help me out here please. What patch does this fix? > Both this one and the x86 one from the day before fix 1cff41494b15cd82c1ec418bb5c ("mm/pgtable: add stubs for {pmd/pub}_{set/clear}_huge") I think both the x86 fix and the arm64 fix should be squashed into that patch at the end. I checked, the only other architecture involving pud_set_huge() and friends is powerpc, and powerpc doesn't have this problem as it only defined those for book3s/64 platforms which have 4 level page tables by definition. Thanks Christophe