Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     bootc@bootc.net, martin.petersen@oracle.com,
        linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: target: sbp_target: Remove redundant assignment
 to pg_size
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq135uoae1h.fsf@ca-mkp.ca.oracle.com>
References: <1620902977-57076-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Date:   Fri, 14 May 2021 23:09:37 -0400
In-Reply-To: <1620902977-57076-1-git-send-email-jiapeng.chong@linux.alibaba.com>
        (Jiapeng Chong's message of "Thu, 13 May 2021 18:49:37 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.ca.oracle.com (138.3.200.58) by SN7P220CA0019.NAMP220.PROD.OUTLOOK.COM (2603:10b6:806:123::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Sat, 15 May 2021 03:09:40 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6b225dd7-9a0d-48c7-ce31-08d9174ee18b
X-MS-TrafficTypeDiagnostic: PH0PR10MB4501:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB4501F91914FC431043A03C3A8E2F9@PH0PR10MB4501.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: iBz0+P6M1NziRGf479TODEtQqcVxsocyQ5skXNKLG8l6O4h2aNoY8WVXrjW2Dy7A/x0a9mlB+dHQ/uXTK2elC92NY8/22y8T7BJD8B4Mzo7fUVGpttdEclUOQ6xSoyihzEjUn0wlwEtJYOzJGKwhEfol5IDz8WtszYrPzAK0TedNndPf82oINbYxmOhCSzjCZK0V7Kg4IckgFwzLkXwFqhSjVDuBjh57/tAm22ZenbixzQx+WKCrRcjuPzG3zMkhewxm15JhONr64t62ZnNsnVE9qAFS1Yfh43oqMLHiu16MU2S31z7splmjFsSizA7nDZ5KJBEwWRw8M0zEotzpmNRL/m/x2iWzkye2Ar4XHyU6x1VHaLBkczogobyeEzqdXWMW5fN011R2Un5W2fyUpytZdsukEHYNU5JSMzJcP3kC0zysB7E/lAH9htuMBSVwR/h6VqdsCVmZyBZdZZ60qpZ7omj1Bp4lEcu/ngQe6Gr4iiZvMNtJpG82VjceBEAvDCp2eOgaeTXSIST9avK80om8PU+E1qe2R9i9lDsW3JcFEiJxgiftsFu6cxIli7b4JYrp7o2cfXwQ7EAYRSRza5odGUAjAlaXCCRH4/JVcnOTp3FdZ1M6L10hCfBaRbsY/Xx2vhFxy+3kSavmfxQBaNV0NBa4wDYIGQafYV00rtY=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(136003)(346002)(376002)(396003)(38350700002)(316002)(55016002)(38100700002)(558084003)(66946007)(5660300002)(36916002)(16526019)(86362001)(6666004)(186003)(478600001)(66476007)(8676002)(8936002)(2906002)(52116002)(66556008)(956004)(6916009)(4326008)(26005)(7696005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?7e8NC6o+oo5IlVRJ2mC0/0GsohL6ARnaw43hDRESzcVZAhwYb1RSz39WqrK6?=
 =?us-ascii?Q?x9fbLUpyvozWHRspfh+EuDzkP4bvLK+udD5lCmFVwoxeWObmeJKXZeMSxuP+?=
 =?us-ascii?Q?qtVbhzvutWirb949AUiIvOGXuWBBmyZkvRsDc54EFpMWkOSSmD1mFAWff2hO?=
 =?us-ascii?Q?GPcAehY2G8+dfiaMD74Wy1SAem2NcADlYxk33t7pUmmDw9dkBHwNyqT9yo7V?=
 =?us-ascii?Q?KI1HiAzhywzexDlSipKXxG3b2Vf5T7VsXgMp41Noz2IBd3WMy5KIc7N9A9Xt?=
 =?us-ascii?Q?WCXxJA6TZzKXZq7oSF/xuONoNA0aP0X+pCimfSfBFakBsWQrTSgOPJ+I5bGX?=
 =?us-ascii?Q?HXhmPhzFf2TLj5HjTVeXM21Ou3GI1Kiuyr+E/xiRnUNVpz0M9PM9W9oxyQk/?=
 =?us-ascii?Q?t7tlkyxTvItJiophho4DLrN+jY9xLFF2LHAslk7HKaBENiw7n1bITlCZCG1X?=
 =?us-ascii?Q?gkhVquIpWcritvirkwFhcI5Hl8rRHSB0Tih9kYEdLme5XTL/guMnZpkcIqhF?=
 =?us-ascii?Q?S2hckMV1C6gBm4LkJcGjLVZauwYRG9+rfrJfoMp3HgU8goBbczUtE+ukasUl?=
 =?us-ascii?Q?N9Nk5aAOR2YXI4cSQ6l5Up5e0sySfh43rm4eQTQ3/E0a4DNy/bydVT4iWkR9?=
 =?us-ascii?Q?nJdEv7QwdMUIfx8uBG4sm0FpvXvpT0He1Wt283uTwR14/7mzMLjjwkpGxV5E?=
 =?us-ascii?Q?OeS624k2dRMjdyM2Le9OifNKDYGLFnL4kZiuuFBf1hF6T0GVaMQ1Kgavt4s4?=
 =?us-ascii?Q?RN/iub6wk4VfFt4W40jjigItFy0lgYKCqy/Z7B3SsAFqGMteA3MHj6HwNzJ1?=
 =?us-ascii?Q?Golsfxz4AUTgNhJ9WiykFvT7bePQkEYLzcoY8OYe5G/9KrBARc9Gw6HaimiK?=
 =?us-ascii?Q?k3Hd1NTGBFFYNwzdwaAgIB9puksA8vVAXgrYMo+GUM/Ni9PsRNTwzEFKy3Wj?=
 =?us-ascii?Q?SfRNj0SaOJjpttsaqVsKBNcIDQZ+zLnPerYnjXF/MfbdSqdsPKSZh7pRFdxF?=
 =?us-ascii?Q?w4inW4KqbiFHj1idag7DFNKynAkUeRr0n2PrEH/Ejsk99NzrlSnKM7frruvh?=
 =?us-ascii?Q?flebCCr54NY1j0IGCkUIjc7YBQP5ojh4wvR/Cyauj+lrDZXeyOZlVfuDZpwd?=
 =?us-ascii?Q?9VqHfeUnKHI7YzTWGvq1sngyZvj7WUTc40e9wUTwSdC2BprR9mM803zD5IGU?=
 =?us-ascii?Q?BpAIyiWZbbQdxtg17WLIKUxRb8gzsaPBn0DcrA4+lLnJaYEeUgYqEnAWtI+/?=
 =?us-ascii?Q?Mc1SwxEWkM9ElF4qiMT9HyifFYCcbSX/CeN8VCXiPyWSOlL6wknKlzP8uFC1?=
 =?us-ascii?Q?tOr0iMg8u2gTXn7cVKas6DmF?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b225dd7-9a0d-48c7-ce31-08d9174ee18b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2021 03:09:41.1845
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LaJ/7mdoSBzCYvCb0WroZElqfcF6/m4NdijUqgFmmSXEPMTdyx02uhC4flp2gtxrG+q9uoLAEUKWXO4OBqbB3gKYlar9b/5cyb70cboTSRM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4501
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9984 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0
 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105150021
X-Proofpoint-ORIG-GUID: 8K9J-MH7DVez6ifjK4lH5Jesvf5_0til
X-Proofpoint-GUID: 8K9J-MH7DVez6ifjK4lH5Jesvf5_0til
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9984 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 malwarescore=0
 spamscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=999 mlxscore=0
 impostorscore=0 adultscore=0 clxscore=1011 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105150020
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Jiapeng,

> Variable pg_size is set to '0x100 << pg_size', but this value is never
> read as it is not used later on, hence it is a redundant assignment
> and can be removed.

Applied to 5.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering