Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1340034pxj; Sat, 15 May 2021 11:22:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuEKfDo5U91GK6kmNnzRXrV0s5nFzHzGO+o36YkM2a/Zctb/ZjRjz5GQl9CpDmDr6sUOH8 X-Received: by 2002:aa7:d818:: with SMTP id v24mr17782286edq.290.1621102950143; Sat, 15 May 2021 11:22:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621102950; cv=none; d=google.com; s=arc-20160816; b=Sln0i9eZ61tJG3IZeyJqrfPDAwecGfR2DWW5u7dBsTZVwZRGD+Rvt0GA2iyOEYQ6tL eFLuguZDpQrr3YKAAfLGNyaEjRVXnzHEJT7qPYSBz44OesskmuZAiR9nlu5V3hJu1P9s zFjSg3bEtO0q8T91HE88iW2cnjil4EEtqPyDwKr9+UGdpooX+4REpe7eKMWMT2MKu5E1 OXEo1G9TKSKY7sscwatjoCU2UNgBXysEm9SqRitmKYs45uw/+9WnUErU+KML96j6/Q2a 8/unibq8i7BOEMT0oVzfEPZ/904U/dFTHwpIGI0XxHxLqcq1MVagCr2YrFZnwsELbH+B 8o6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=n2dGKEfA7WjlHjt72sNJR7U+IYZzz6Q6cY5bfMgcN5Q=; b=gYfn3wYkDhp/1OXrZdrCWZ5WPGnyj3AeMo2ZaPPO+jl2toSxcD+bsOV1u022n04wMe 09QlsP47EwY0gp7NYMmeYGaX7ngoGxzXvulxb9CjZgXOCDP15BXrBDSiEnBOZOr81lrG DpgOTacc4+/WY9Jo79Pfrx3neA2ADs4UsuO98z9iZ7obP/Pxa0ZjX/9Dq3CaS8/TlcZB g2Ppy9egnJPnMzOMdsO0OTa8bfl6dRk8HDHjiHweP/ToXsEDgazNixjAC/ryhGjNusW7 Z9rHwo34CobQEJtYXtlz4ML4X74QXLJ8Dj5Qm4J9qFfXl+U6n0cCo+7XUkWN83PVtRw6 xpDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id by20si32619ejb.660.2021.05.15.11.21.55; Sat, 15 May 2021 11:22:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233430AbhEOIik (ORCPT + 99 others); Sat, 15 May 2021 04:38:40 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:50186 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234183AbhEOIic (ORCPT ); Sat, 15 May 2021 04:38:32 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 7E4651C0B81; Sat, 15 May 2021 10:37:18 +0200 (CEST) Date: Sat, 15 May 2021 10:37:17 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Paolo Abeni , Willem de Bruijn , "David S. Miller" , Sasha Levin Subject: Re: [PATCH 5.10 380/530] udp: never accept GSO_FRAGLIST packets Message-ID: <20210515083717.GD30461@amd> References: <20210512144819.664462530@linuxfoundation.org> <20210512144832.263718249@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2iBwrppp/7QCDedR" Content-Disposition: inline In-Reply-To: <20210512144832.263718249@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2iBwrppp/7QCDedR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Paolo Abeni >=20 > [ Upstream commit 78352f73dc5047f3f744764cc45912498c52f3c9 ] >=20 > Currently the UDP protocol delivers GSO_FRAGLIST packets to > the sockets without the expected segmentation. >=20 > This change addresses the issue introducing and maintaining > a couple of new fields to explicitly accept SKB_GSO_UDP_L4 > or GSO_FRAGLIST packets. Additionally updates udp_unexpected_gso() > accordingly. >=20 > UDP sockets enabling UDP_GRO stil keep accept_udp_fraglist > zeroed. What is going on here? accept_udp_fraglist variable is read-only. Should this be dropped? Should=20 commit d18931a92a0b5feddd8a39d097b90ae2867db02f vxlan: allow L4 GRO passthrough =20 be cherry-picked? Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --2iBwrppp/7QCDedR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmCfiD0ACgkQMOfwapXb+vIJjwCeP1CTpZD86zOct2i7KWCsnPQZ aPoAnizcfWB9nBgjVVeSJsrz85m+8HnB =7GSI -----END PGP SIGNATURE----- --2iBwrppp/7QCDedR--