Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: AjP9T3QgWO4O9KYeet0hyx/WgoTC2T6BAZSRvC6SuKtnkE4REsJ0J8RbOmhlbo5rAoMs1uUwfh
 ePYS1JX8NH9lzRWu3c1p1mPcAMXpRIKkh45h+T2/x3ZCZYPIR1ny/NhwBe5QCa+88bRluZJwAU
 fkw21x5m0psArqczqe9xkdY3NLlqM2ZaCOdlHgt8vGBeQcuvGPi8jVCMtgW0HmGuoJSdPRYc9f
 A/LHOQs/bC/niaOci9WwaWSSQ8nO/9SWuv/fXeoJzY5KHkC0Oy9fiPKAxyDPytHCXYYEuy+0Di
 iQQ=
From:   <Nicolas.Ferre@microchip.com>
To:     <shenyang39@huawei.com>, <davem@davemloft.net>, <kuba@kernel.org>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <Claudiu.Beznea@microchip.com>
Subject: Re: [PATCH 07/34] net: cadence: macb_ptp: Demote non-compliant
 kernel-doc headers
Thread-Topic: [PATCH 07/34] net: cadence: macb_ptp: Demote non-compliant
 kernel-doc headers
Thread-Index: AQHXSYhcfQ7X2PpkrEmud7cbBvaxSw==
Date:   Sat, 15 May 2021 12:46:45 +0000
Message-ID: <bbfb694c-5d48-137c-e394-4d718887f03d@microchip.com>
References: <1621076039-53986-1-git-send-email-shenyang39@huawei.com>
 <1621076039-53986-8-git-send-email-shenyang39@huawei.com>
In-Reply-To: <1621076039-53986-8-git-send-email-shenyang39@huawei.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <1F93986D1338744F9A042CEAF862C7BA@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 33b18e2b-4331-4747-be2b-08d9179f7f8a
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2021 12:46:45.5114
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mLHNCijTuWk2YajUJ69aNMZIIDxTQ4s2kVkBwrEQMttk36ucSiH3QGNYDmh2lTaQmj8sHdfVs9pix///HgdhtHps0TTjhvwqJMHJgcNJxIo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2869
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 15/05/2021 at 12:53, Yang Shen wrote:
> Fixes the following W=3D1 kernel build warning(s):
>=20
>   drivers/net/ethernet/cadence/macb_ptp.c:3: warning: This comment starts=
 with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/=
kernel-doc.rst
>=20
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>

Ok, if it raises a warning.

But I would prefer that you add drivers/net/ethernet/cadence/macb_pci.c=20
with same change to a combined patch.

Regards,
   Nicolas


> Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
> ---
>   drivers/net/ethernet/cadence/macb_ptp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/cadence/macb_ptp.c b/drivers/net/ethern=
et/cadence/macb_ptp.c
> index 283918a..5c368a9 100644
> --- a/drivers/net/ethernet/cadence/macb_ptp.c
> +++ b/drivers/net/ethernet/cadence/macb_ptp.c
> @@ -1,5 +1,5 @@
>   // SPDX-License-Identifier: GPL-2.0-only
> -/**
> +/*
>    * 1588 PTP support for Cadence GEM device.
>    *
>    * Copyright (C) 2017 Cadence Design Systems - https://www.cadence.com
> --
> 2.7.4
>=20


--=20
Nicolas Ferre