Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 4/9] x86/idt: remove address argument to
 idt_invalidate()
To:     "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20210515014400.2999028-1-hpa@zytor.com>
 <20210515014400.2999028-5-hpa@zytor.com>
From:   Andy Lutomirski <luto@kernel.org>
Message-ID: <bb26d2d3-71c7-5513-5d0f-580f9da09d88@kernel.org>
Date:   Sat, 15 May 2021 08:27:38 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210515014400.2999028-5-hpa@zytor.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/14/21 6:43 PM, H. Peter Anvin wrote:
> From: "H. Peter Anvin (Intel)" <hpa@zytor.com>
> 
> There is no reason to specify any specific address to
> idt_invalidate(). It looks mostly like an artifact of unifying code
> done differently by accident. The most "sensible" address to set here
> is a NULL pointer - virtual address zero, just as a visual marker.
> 
> This also makes it possible to mark the struct desc_ptr in
> idt_invalidate() as static const.
> 
> Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>

Acked-by: Andy Lutomirski <luto@kernel.org>

> -	idt_invalidate(phys_to_virt(0));
> +	idt_invalidate();

This hunk is an actual change, but I'm not sure it needs to be mentioned
in the changelog.