Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\))
Subject: Re: [PATCH v2] samples/kprobes: Fix typo in handler_post()
From:   "Koderer, Marc" <marc@koderer.com>
In-Reply-To: <1620979810-12779-1-git-send-email-yangtiezhu@loongson.cn>
Date:   Fri, 14 May 2021 11:28:07 +0200
Cc:     Jonathan Corbet <corbet@lwn.net>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Johannes Thumshirn <jthumshirn@suse.de>,
        Heiko Carstens <hca@linux.ibm.com>,
        Jisheng Zhang <jszhang@kernel.org>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <BA687AE0-EB7F-4A27-9868-5CCD83FF1E76@koderer.com>
References: <1620979810-12779-1-git-send-email-yangtiezhu@loongson.cn>
To:     Tiezhu Yang <yangtiezhu@loongson.cn>
Precedence: bulk


> On 14. May 2021, at 10:10, Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> 
> It should use post_handler instead of pre_handler in handler_post().
> 
> Fixes: e16c5dd5157e ("samples/kprobes: Add s390 case in kprobe example module")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>


LGTM.
Acked-by: Marc Koderer <marc@koderer.com>

Thanks.

> ---
> 
> v2: rebase on the latest mainline kernel
> 
> samples/kprobes/kprobe_example.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index c495664..602db3f 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -89,7 +89,7 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs,
> 		p->symbol_name, p->addr, regs->status);
> #endif
> #ifdef CONFIG_S390
> -	pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n",
> +	pr_info("<%s> post_handler: p->addr, 0x%p, flags = 0x%lx\n",
> 		p->symbol_name, p->addr, regs->flags);
> #endif
> }
> -- 
> 2.1.0
>