Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   yanfei.xu@windriver.com
To:     paulmck@kernel.org, josh@joshtriplett.org, rostedt@goodmis.org,
        mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
        joel@joelfernandes.org
Cc:     rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] rcu: wrong stall log when only one task blocked within RCU read-side
Date:   Sun, 16 May 2021 00:45:11 +0800
Message-Id: <20210515164511.3547618-1-yanfei.xu@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from pek-lpggp1.wrs.com (60.247.85.82) by HK0PR01CA0055.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Sat, 15 May 2021 16:45:22 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e7a49b72-2f4f-4f28-13fa-08d917c0d649
X-MS-TrafficTypeDiagnostic: SJ0PR11MB4877:
X-Microsoft-Antispam-PRVS: <SJ0PR11MB48770F67EFC0B9356B34AB1BE42F9@SJ0PR11MB4877.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tUEDYCTCISYg5pmLg6G4EB0sWviaoWXGSbHe9W/huZcDg6Mnd0x9VL53KVHekQ0XCIGzBEVBmPGZYf/F8mR3ccEC3NWYj+Nu5/bu5r0M0FrVam1q0O8V+590DIHb4Y/Az8IMm4ebbEVZ/CUvMie8QpymsDdJJ1LGnXbwnJrKpGvvalUr0VqTQmpjB5gsw7UZxwZspHm/ZuYJiKaW1FAjgaemjxWMAZNY1OWfjUoM3PyEnyaD36SG7WkdJ45WBAu3WeccwhuOUhka5Xg9clBF/BED9m+gBOiJosSGp0Nn1DqC3jigsfMygcHp/Mx3j8k75hT4soFgoD5xdeSLstZ3FILuP44hKiVc08XBOv5GpL2ToCxA+nNLuPWHcDXJNqv9HsTJTHTHe4ZCU/gSEGsWxqRZ2Ah6hvn8PDeOU5MNP1pJw/n2Uom+Azxjp+ijvX/n+6R3zzvzB9hCH6FOeaODnOknrfNdP6NqM17nZB2AxNwd49dc3rWEePkWFqlLCYKMITbIJkKHH8yH4FSlmB262jd48VPzQY5vjoNkvDDFG2K+ghcPQV3PXSZ3vWwkKYpzcbuocAIkFavRTL9pLZi1dRKy+vYCT04rAcl1x1kS++YOF68k7gOG8ZoDtjNuwfD6XtLRZdmRi4JE8l/eheDSzw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4241.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39840400004)(366004)(136003)(376002)(396003)(8936002)(66556008)(66476007)(6506007)(5660300002)(66946007)(8676002)(6666004)(956004)(52116002)(6486002)(38100700002)(6512007)(9686003)(36756003)(38350700002)(83380400001)(478600001)(15650500001)(4326008)(26005)(2616005)(16526019)(186003)(316002)(1076003)(2906002)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?nna2EaZGJamPm0w0HiPUThErM9aXwHTIGaiZG+yMuWVmz7s0iAAkwmlwzIr4?=
 =?us-ascii?Q?pgikaRNXH1oN29gG1MNK9ejFCG0vRdZGmSLcQcX2kE13Xx+tlb8hFQKEGlcv?=
 =?us-ascii?Q?QnE6bdoy0EoU9btJ820f7I5b9ViEuwl2d2OIhYccmsjz6bbUWlrZrGI4m05I?=
 =?us-ascii?Q?YRXHu76ukhkSioAmaLD001Eab3MpjAn8aKjtfZexXtM/yawxE8/vhXN4hOaK?=
 =?us-ascii?Q?wKn0cZcK7CsaWbxRhMQPhAyAU/abpaZXHBkGvBK2nfJC8FlwBZX5OkNe3+g1?=
 =?us-ascii?Q?QNtiyhrogrZooqq1CLKTBoKL+axdYQRRvQo+Nc338FGpwIYhf/yU2VrwLI+G?=
 =?us-ascii?Q?domlKNC2EBEj6EpAoI4KejRo9dEaLrBcaFKP7/xpYLB2du+v0bpGdLIX470i?=
 =?us-ascii?Q?qPvB7u+uVKnJWneMqYm9fGJaAfuHimPuCE/XCyZade4gFwl/yO/lXl1nt+QP?=
 =?us-ascii?Q?fioHRRGuLFvfM2aHDa3fqagNj2ZABJMErSK5GXsl/9a7OaT8jFFBu0hI6wBO?=
 =?us-ascii?Q?2pvvUuirKmjlN7+qBh+HmFMD8Uo7NtT7EmuoDVEyQzH+DsD9qA8T04VoqcaW?=
 =?us-ascii?Q?1AUxiyngop7T9YVFwj90gMNp6IO2AOVWFNUZBbvgDOuIof5DGrrCtT81URxP?=
 =?us-ascii?Q?CrgxMOvsNGbY9aMUJsp+xnK7KTHYNdpAfuUzQixWlXyMqWoXWvEiJ/YCjqXN?=
 =?us-ascii?Q?MSfSMzn+t+1mAjPpXrNPtV4Sbc2U5aJ9tNa0VdxtTTnJhF8WCqs6PL9KXbbB?=
 =?us-ascii?Q?SDTmINYkJPlxTDmfKvT/QobEkIzK/kksXXZHIm+lmd/sCIfMpKGmIzhq8MVT?=
 =?us-ascii?Q?ncimJSJ5sSOzGagLkfHpWPDVPBMqnzBnYPrlVx0RplSnwEBN9VwKdWlBUHN3?=
 =?us-ascii?Q?uXapaDycPgi2uyTfkuUN5Ue3r295bPOfI69Zhj2VSQN+G5KetIzE/r/M6emG?=
 =?us-ascii?Q?ekKCed2lMuY9a5CC+dPyGCEHqOLSvjdDJz0fpJ5cO1EYp31DOo1pmzuo/hmZ?=
 =?us-ascii?Q?U5+iVl9CzwMFpXmO1v8kytoh9dXdrYQils1QYCt3A52O803kehxpZdEYmwx5?=
 =?us-ascii?Q?A7U0zKo9225EJkLbD9x4+84HwXrR3tHuJSaSFpva6i+rREH2fcq8eDH4mL87?=
 =?us-ascii?Q?BV5QpBu+RM3OfjCjaBxo6DN9BIiN4lF4KZaPoFDXoMuBQ3h3Vrtjx2jJunC5?=
 =?us-ascii?Q?xJ6bYK7Jm1YwSQeOhezr7md4faVTfJTsgTupvkBD3S6dBJmSbyhcDCj7On32?=
 =?us-ascii?Q?BCWc5bA2WmDv9wwnPNgTS3PfBqC/l9npSYkWZvm4s7/haoavelOlbdl6EaMw?=
 =?us-ascii?Q?cioMrr5eTZUGqCEJ6xMChp44?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7a49b72-2f4f-4f28-13fa-08d917c0d649
X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4241.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2021 16:45:24.7897
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4TQbkhIo++ZGiJzVrH0TmHKo4TwWPXFbmtwOMEue1XQSTzrybNWSMpkuwsgC13sVwrsjSOlnf+8UqI0WKKmkpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4877
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Yanfei Xu <yanfei.xu@windriver.com>

The for loop in rcu_print_task_stall() always omits the first blocked
task in RCU read-ride critical section. It will cause status of the
blocked task can't be printed and lead a wrong ndetected variable.
With the above, the wired stall log comes, All QSes seen, but qsmask
still is not zero:

rcu: INFO: rcu_preempt detected stalls on CPUs/tasks:
rcu:    Tasks blocked on level-1 rcu_node (CPUs 12-23):
        (detected by 15, t=6504 jiffies, g=164777, q=9011209)
rcu: All QSes seen, last rcu_preempt kthread activity 1
(4295252379-4295252378), jiffies_till_next_fqs=1, root ->qsmask 0x2
BUG: sleeping function called from invalid context at
include/linux/uaccess.h:156
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 70613, name:
msgstress04
INFO: lockdep is turned off.
Preemption disabled at:
[<ffff8000104031a4>] create_object.isra.0+0x204/0x4b0
CPU: 15 PID: 70613 Comm: msgstress04 Kdump: loaded Not tainted
5.12.2-yoctodev-standard #1
Hardware name: Marvell OcteonTX CN96XX board (DT)
Call trace:
 dump_backtrace+0x0/0x2cc
 show_stack+0x24/0x30
 dump_stack+0x110/0x188
 ___might_sleep+0x214/0x2d0
 __might_sleep+0x7c/0xe0

Fixes: c583bcb8f5ed ("rcu: Don't invoke try_invoke_on_locked_down_task() with irqs disabled")
Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
---
 kernel/rcu/tree_stall.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h
index 59b95cc5cbdf..b72311d24a9f 100644
--- a/kernel/rcu/tree_stall.h
+++ b/kernel/rcu/tree_stall.h
@@ -280,8 +280,8 @@ static int rcu_print_task_stall(struct rcu_node *rnp, unsigned long flags)
 			break;
 	}
 	raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
-	for (i--; i; i--) {
-		t = ts[i];
+	while (i) {
+		t = ts[--i];
 		if (!try_invoke_on_locked_down_task(t, check_slow_task, &rscr))
 			pr_cont(" P%d", t->pid);
 		else
-- 
2.27.0