Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH iproute2-next v3] lib/fs: fix issue when
 {name,open}_to_handle_at() is not implemented
To:     Petr Vorel <petr.vorel@gmail.com>
Cc:     Heiko Thiery <heiko.thiery@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, stephen@networkplumber.org,
        Dmitry Yakunin <zeil@yandex-team.ru>
References: <20210508064925.8045-1-heiko.thiery@gmail.com>
 <6ba0adf4-5177-c50a-e921-bee898e3fdb9@gmail.com>
 <CAEyMn7a4Z3U-fUvFLcWmPW3hf-x6LfcTi8BZrcDfhhFF0_9=ow@mail.gmail.com>
 <YJ5rJbdEc2OWemu+@pevik> <82c9159f-0644-40af-fb4c-cc8507456719@gmail.com>
 <YJ/+C+FVEIRnnJBq@pevik>
From:   David Ahern <dsahern@gmail.com>
Message-ID: <a20600f9-25e0-c2e4-079e-9aca1178e409@gmail.com>
Date:   Sat, 15 May 2021 12:26:12 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <YJ/+C+FVEIRnnJBq@pevik>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/15/21 10:59 AM, Petr Vorel wrote:
> Hi David,
>> On 5/14/21 6:20 AM, Petr Vorel wrote:
> 
>>>>> This causes compile failures if anyone is reusing a tree. It would be
>>>>> good to require config.mk to be updated if configure is newer.
>>>> Do you mean the config.mk should have a dependency to configure in the
>>>> Makefile? Wouldn't that be better as a separate patch?
>>> I guess it should be a separate patch. I'm surprised it wasn't needed before.
> 
> 
> 
>> yes, it should be a separate patch, but it needs to precede this one.
> 
>> This worked for me last weekend; I'll send it when I get a chance.
> 
>> diff --git a/Makefile b/Makefile
>> index 19bd163e2e04..5bc11477ab7a 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -60,7 +60,7 @@ SUBDIRS=lib ip tc bridge misc netem genl tipc devlink
>> rdma dcb man vdpa
>>  LIBNETLINK=../lib/libutil.a ../lib/libnetlink.a
>>  LDLIBS += $(LIBNETLINK)
> 
>> -all: config.mk
>> +all: config
>>         @set -e; \
>>         for i in $(SUBDIRS); \
>>         do echo; echo $$i; $(MAKE) -C $$i; done
>> @@ -80,8 +80,10 @@ all: config.mk
>>         @echo "Make Arguments:"
>>         @echo " V=[0|1]             - set build verbosity level"
> 
>> -config.mk:
>> -       sh configure $(KERNEL_INCLUDE)
>> +config:
>> +       @if [ ! -f config.mk -o configure -nt config.mk ]; then \
>> +               sh configure $(KERNEL_INCLUDE); \
>> +       fi
> 
>>  install: all
>>         install -m 0755 -d $(DESTDIR)$(SBINDIR)
> 
> Thanks a lot, please send it.
> 
> I know this is only a fragment, but:
> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
> 
> -nt is supported by dash and busybox sh.
> 

That helps. My concern was all the sh variants.