Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 15 May 2021 19:32:08 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     Wei Liu <wei.liu@kernel.org>,
        Michael Kelley <mikelley@microsoft.com>,
        vkuznets <vkuznets@redhat.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Mohammed Gamal <mgamal@redhat.com>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Dexuan Cui <decui@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] clocksource/drivers/hyper-v: Re-enable
 VDSO_CLOCKMODE_HVCLOCK on X86
Message-ID: <20210515193208.dy57jmbhfdmzt2mz@liuwe-devbox-debian-v2>
References: <20210513073246.1715070-1-vkuznets@redhat.com>
 <MWHPR21MB15932C5EC2FA75D50B268951D7519@MWHPR21MB1593.namprd21.prod.outlook.com>
 <20210515154335.lr4hrbcmt25u7m45@liuwe-devbox-debian-v2>
 <87h7j324w2.ffs@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87h7j324w2.ffs@nanos.tec.linutronix.de>
Precedence: bulk

On Sat, May 15, 2021 at 09:06:37PM +0200, Thomas Gleixner wrote:
> On Sat, May 15 2021 at 15:43, Wei Liu wrote:
> 
> > On Thu, May 13, 2021 at 01:29:12PM +0000, Michael Kelley wrote:
> >> From: Vitaly Kuznetsov <vkuznets@redhat.com> Sent: Thursday, May 13, 2021 12:33 AM
> >> > 
> >> > Mohammed reports (https://bugzilla.kernel.org/show_bug.cgi?id=213029)
> >> > the commit e4ab4658f1cf ("clocksource/drivers/hyper-v: Handle vDSO
> >> > differences inline") broke vDSO on x86. The problem appears to be that
> >> > VDSO_CLOCKMODE_HVCLOCK is an enum value in 'enum vdso_clock_mode' and
> >> > '#ifdef VDSO_CLOCKMODE_HVCLOCK' branch evaluates to false (it is not
> >> > a define). Use a dedicated HAVE_VDSO_CLOCKMODE_HVCLOCK define instead.
> >> > 
> >> > Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> >> > Reported-by: Mohammed Gamal <mgamal@redhat.com>
> >> > Fixes: e4ab4658f1cf ("clocksource/drivers/hyper-v: Handle vDSO differences inline")
> >> > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> > [...]
> >> 
> >> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
> >> 
> > Applied to hyperv-fixes. Thanks.
> 
> It's already in the tip tree...

Okay. I will drop it. Thanks.