Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1732327pxj; Sun, 16 May 2021 02:24:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOCyHmLMCgo+mFVTpQNhp9daWRnVwRKCDOqMQ0xIk1QEKtuLyn+CpzzSmvGX40XgmhudCR X-Received: by 2002:a17:907:1629:: with SMTP id hb41mr58132675ejc.316.1621157046825; Sun, 16 May 2021 02:24:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621157046; cv=none; d=google.com; s=arc-20160816; b=qn6cKdsCSmiZucfLCg2i9N3WjrdzWacFxcP3+PkQE6wt/VChwB+CT2uCiUWyjxEiEn kHQ+EVFwtgIWRhsX09TNkgVOL5uCE+EFg200q6x7+HqdgI6emFMmRp+mq/++ZCJFr20R LNm0OyWiSUn2Y+czwIhTQMw7SMZCTf+Vd+abrBi5vGM4ueZi4Bb/CtS1JUhHbgKOKhaZ UeIycKZhRqGSO5iwBXiGM4peXdHJ+DgYSG6hnuA8dfPho/rAP15m22XwhK9rMUXGgUB8 Q0L/DoD9gNL7f96fHur82KV201ibOIuGZEEMQfFMHyqJh9EWePWynLUXSmH1gU+ghNcS SGlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=DceUy+2NUnlC8ur/URFEkVm8PqULS5zh5pj+vzZYRL4=; b=V57jlC5V1s/Qx8V+YkasmwM4vTOhC3rA5k82WPZm4T3PDN6pKOcnFLBLozESXpAvL2 GrQcvDCj0ew7RnLTFqnB2BoA/blE7K93kHqmjQxPZ8lBbO0ZWsx+uSeUOs9SzJFZNOl0 6/fe6NGLAITFY4A8yWdW7oVrTRMvOeWcGjkB3XRO4uZgZFekJiRApoFWQeYUgYR1EANb mOFIUDeAIDcMzBuuWUdb748lqSq0m6FPF5ne7kTcwZd4wXahsKItdYejiGT+PuZzHmUn yioEDVpYK8hkBsBuFZdHTPpzivCrHdgggOft/E68/FfIVllH03YExyM23bkc0S5kpHFO WmiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kemnade.info header.s=20180802 header.b=UU1A8Js7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id zg9si12487179ejb.436.2021.05.16.02.23.44; Sun, 16 May 2021 02:24:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kemnade.info header.s=20180802 header.b=UU1A8Js7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234978AbhEOU4s (ORCPT + 99 others); Sat, 15 May 2021 16:56:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbhEOU4p (ORCPT ); Sat, 15 May 2021 16:56:45 -0400 Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a01:238:4321:8900:456f:ecd6:43e:202c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB48DC061573 for ; Sat, 15 May 2021 13:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DceUy+2NUnlC8ur/URFEkVm8PqULS5zh5pj+vzZYRL4=; b=UU1A8Js74rkX+Cal28SjjTTrfj IuzAb92N5bRe39OKkLcPvjeiEjAPCV3JmDbQHBiud8IZ1c3I2BtbH8P/cs6AS+IK7rrCxyoe5K/GK B8mxA2JvQcVj5IeiJkUQLrjIhpqblQoFLj7Pd9sSvUz0yInnFMs1ljVfQdq0xWMU2LRI=; Received: from p200300ccff3902001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff39:200:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1li1Jj-0005cR-Pt; Sat, 15 May 2021 22:55:24 +0200 Received: from andi by aktux with local (Exim 4.92) (envelope-from ) id 1li1Jj-0001Xi-FO; Sat, 15 May 2021 22:55:23 +0200 From: Andreas Kemnade To: lee.jones@linaro.org, andreas@kemnade.info, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org Subject: [PATCH RESEND] mfd: rn5t618: fix IRQ trigger by changing it to level mode Date: Sat, 15 May 2021 22:55:18 +0200 Message-Id: <20210515205519.5884-1-andreas@kemnade.info> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.0 (-) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During more massive generation of interrupts, the IRQ got stuck, and the subdevices did not see any new interrupts. That happens especially at wonky USB supply in combination with ADC reads. To fix that trigger the IRQ at level low instead of falling edge. Fixes: 0c81604516af ("mfd: rn5t618: Add IRQ support") Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c index ecddd7b6500e..a852eef1f4d2 100644 --- a/drivers/mfd/rn5t618.c +++ b/drivers/mfd/rn5t618.c @@ -109,7 +109,7 @@ static int rn5t618_irq_init(struct rn5t618 *rn5t618) ret = devm_regmap_add_irq_chip(rn5t618->dev, rn5t618->regmap, rn5t618->irq, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + IRQF_TRIGGER_LOW | IRQF_ONESHOT, 0, irq_chip, &rn5t618->irq_data); if (ret) dev_err(rn5t618->dev, "Failed to register IRQ chip\n"); -- 2.29.2