Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1733055pxj; Sun, 16 May 2021 02:25:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/a3Zp075QuD0j5B/rcPusUNLDiX7FFHCIC3ASstlVDB+CvH33qDDcN676JvFvDvyv/Ykz X-Received: by 2002:a05:6402:498:: with SMTP id k24mr26352285edv.80.1621157141166; Sun, 16 May 2021 02:25:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621157141; cv=none; d=google.com; s=arc-20160816; b=Z1DmHHEotcV2WvGelamVGiB1e66cHAR9f5r2GhjtFbgxKlmmBGet52SJGr80e1UEAW nZb8VrT0xqu2xqbl/+EOCaryN7u1hIKfcy4xXd5S+5ZzH66aspFckiNxXq7dlLgyeiHw tLrz0MR4K7AnolbwoEvBHwy6e14asgukyTedG9b7SSMZfvpHIYkTjajdhmudD5ZyO1/Y 2V1CygnApsM6umxaEqES4QsYBpgME6wIpr4G5r1ePzEQ/JbM7cbETifWd9t5BYIFbMJs wqKauIRmrs/pNWUjYwLmefhU1aRo/+GishzNqeG/GynFHkbrfjkOoJ82UPe0n6CvWIwk MzUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hyyxptrN6opDfMyDe82jUzcLX0UK5gBJjKQrYKblEk0=; b=bN8qZvE6xHNbo2pioaJi2Xjm9cTHf5g0PspwCw3+K8Ck1nYhFmh2lCKFv2bPQrq+sm jcElTmyXQUJAGiURyRaSk09BAVzHK+1QZVd3P1OwPAZ7UcUYIVBCZtDZQ0N+XEFKbTKA sXDfb2/aHUKHWr4/4AWowARNeCBo/Pq+7eGOCw7wVxWWihWccSeIYltjIz8NLf/0xiTm d3HnrePfcOUFFKEYrADoDf1P6M4MSwcMf6VKAGpMon+MWEB01pbT/oB75TmCboAQKioD PZBAaqZNIBmSxacb8oiS+pOojrq8KIGTzXSJq/9f2lriT7HbxQvWeBRe2kUZOL2QCLKu w/ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=EQfXeu58; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o6si12823767edi.226.2021.05.16.02.25.17; Sun, 16 May 2021 02:25:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=EQfXeu58; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235015AbhEOVEL (ORCPT + 99 others); Sat, 15 May 2021 17:04:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbhEOVEJ (ORCPT ); Sat, 15 May 2021 17:04:09 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DAEEC061573; Sat, 15 May 2021 14:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hyyxptrN6opDfMyDe82jUzcLX0UK5gBJjKQrYKblEk0=; b=EQfXeu58xeH/wF2c62hm+Hpm+D llBIBgZ4UtGnuztEh0gmSWjIv1tcLsdI5waiS+I6gSU6yAaUzD1XUM3FuaBj/C9Sl8u9yeaqcYgP6 J0dS3fJPx+9H9r+6n63o8YiSNP/CwbTYB4U2fzBgYYICn3+WZLDl/e35s+shaUWpEQTTkR1AE8she Hp5FLL88GPsErt9Ut85nULimIJCc6raoa0KrbLYzOjMABU4wDVWZ2kammutEnvTiqke6EL3TF249o EDz6njNYUOtIMxraQ1hVDi6uYV8KfBX4JkJihG6if7PhAtZbxmyTV4V7J5/dWVQjdiV1TQnF3pE2+ 85x6T6Lw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1li1Qn-00Azjf-5i; Sat, 15 May 2021 21:02:41 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 63E5E98659E; Sat, 15 May 2021 23:02:38 +0200 (CEST) Date: Sat, 15 May 2021 23:02:38 +0200 From: Peter Zijlstra To: Khaled ROMDHANI Cc: mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH-next] sched: Fix Null pointer derefrence Message-ID: <20210515210238.GG5618@worktop.programming.kicks-ass.net> References: <20210515164645.22849-1-khaledromdhani216@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210515164645.22849-1-khaledromdhani216@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 15, 2021 at 05:46:45PM +0100, Khaled ROMDHANI wrote: > The 'curr' variable could be NULL and derefrenced by > pick_next_entity. Fix this by adding a check that prevent > the invocation of pick_next_entity with a NULL passed argument. And why exactly is that a problem?