Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1733492pxj; Sun, 16 May 2021 02:26:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycuE+/AAcT0eLz6IWinbtf5R1/T0EHzbrZCq60I4iaKrnzK0HMxaqkehyXsM6ayvickCu3 X-Received: by 2002:a17:906:1cda:: with SMTP id i26mr12642245ejh.412.1621157196040; Sun, 16 May 2021 02:26:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621157196; cv=none; d=google.com; s=arc-20160816; b=CK7ofSIh/3KNFbZ6WdsbCoVW29iFVro1q4H/fcYT3SEYxoOpv/qnD6HQYPnQFt/D6Z QAM/ueISNHoSjfb0hJCGs0J9NM5eb93EA7BIf4Re8GoMEhMh+T6WFiiBEHWE7ck0obLx kViH5Y7QRTqWen8ANkK8U2a7S33WesV45jciqu57wR7c4GZzDTh8wwCCf0sLVbAvaEeY HFTkur0YfVQ0ENnGaturuBEMZpQLdV+gxJTxfkElbZhU7W5r7jAVyUQomx4WiuPzXgxV Pmsn7xCRHdFwA8JmDIervehEa61D1xCIUF6+wNXl9uzW1mBDWUP8wxoSmthKEsiih43N w7og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RJWqyMKE1PxEzZ0wQRXQI9bbKJMETBb0mIpGg8RhjH8=; b=0GVLoWQsKAdKaKx7te2FzSexeXLeahQSrLZ5GqPkS5xsZFkqMmqEzPlQ3o7ROvZkwx 6NksbGqV0wRRG81vM+4lxmclRXMSzRRymSYg/aIQ8oTYTJOj2oGJHw9NTkDWpzPnM3pH GaU5ctim8N2JPQwM0IXKNS67kC6cW1zjj37fBI3t55ZKCYbbLzotqXYIyJWy9bP/o7CK gn8gPqVOpeXuOCVSL/S2Lt/VRQCwiuxCaNmaZFffcfCR1xLOGUG4l/bDpgb4ds+Zgh3w BX5hbADa1AVY/6guvm5O9ZpO9JQlAVMy2fgRAlerd7wZP0i0O7Wn6MSsVG1+UcMNe+V1 Fbjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=WL7jvMlb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q6si10638677ejn.673.2021.05.16.02.26.13; Sun, 16 May 2021 02:26:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=WL7jvMlb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235049AbhEOVGK (ORCPT + 99 others); Sat, 15 May 2021 17:06:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbhEOVGK (ORCPT ); Sat, 15 May 2021 17:06:10 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3944C061573; Sat, 15 May 2021 14:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RJWqyMKE1PxEzZ0wQRXQI9bbKJMETBb0mIpGg8RhjH8=; b=WL7jvMlbkEOGS+ud1cSYdSsj51 dcGDvBs6x08LSEc35XBKUpkF70LUSNc+hhemtk2S4+c/tAmfggUjHeHHRPKMihpbtwZHXXWMH7Vu4 1pA/R4PKWYRZDdwjyyFnsshOyT7UgrsIh5iWyznZPdtGkAF1Pc1oNjogb3DylTIhFyU9phh9d3pGf ehmC609SriC51RX55TShs5fP1dxzA/Qczob6GsJPBx8tNGP/k72m4q5u+GNNSS43YWRBSz2ZtLGxl cYE/dM/R3RYiTQ0bPwz8sOR+zs3Xd5h7j/HOlfigVJeR8HuoYCbsxoQqiNNm2bdlewu0oslRaFlFI +DX5qvHA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1li1SD-00BW6D-4a; Sat, 15 May 2021 21:04:11 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 5AD4C98659E; Sat, 15 May 2021 23:04:06 +0200 (CEST) Date: Sat, 15 May 2021 23:04:06 +0200 From: Peter Zijlstra To: Khaled ROMDHANI Cc: mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH-next] sched: Fix Dereference after null check Message-ID: <20210515210406.GH5618@worktop.programming.kicks-ass.net> References: <20210515171117.23240-1-khaledromdhani216@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210515171117.23240-1-khaledromdhani216@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 15, 2021 at 06:11:17PM +0100, Khaled ROMDHANI wrote: > The group_cfs_rq derefrence the 'se' variable that could > be passed as NULL pointer. Fix this by adding a check > against the sched entity 'se' before the derefrence. > > Addresses-Coverity: ("Dereference after null check") > Signed-off-by: Khaled ROMDHANI Please, burn that piece of garbage known as Coverity and go do something useful.