Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1744960pxj; Sun, 16 May 2021 02:52:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGCC1Ta9QGwRcWJzJNZANSNiAC3ODPeGySGK6urZFSD7OGgiJXyqQ8C9oeLHbJFTRKpM25 X-Received: by 2002:a17:906:724b:: with SMTP id n11mr56917978ejk.338.1621158761959; Sun, 16 May 2021 02:52:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621158761; cv=none; d=google.com; s=arc-20160816; b=pbSFOFOQ+1WElBDqwUHHfA2oTzP29+Awe1tq739mCdYcvOz2zc9iwm1KXTsV5+ACCv HYmN39llmhfZkt67IhO/73gPFkHYzNUtDPZJJu7XL8V3som94koe4P+mYKkB20aevPjn ywdo3ava8VLWh0yAmjqUfgWoNdwEfwgk8AtC1sdmimsERe9ISuaSygDhBVeLbD0YDtIy Ov0Av8SncMMOhxOa2woEW/h0nTIllyBwxxzF478LNWBTxWeayolh0aSkVoqqcpdpY6d4 Xt5nGJpSHNbWPnlZSdheRmJ4IUlzcB9aCa8pyrNKRZtiaUg3jAY5dV5Hl1vAfA3i9rg9 x6SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RP7yGAEHZlhCRQ2Dd9FV88IXokX2WkuH4I1RMy1fDuA=; b=I6xOeWCcOlWuitOHl9AyG563IUUWAbwZj//QklN6Y89BB6ZoAUWzJ/NJ6k5FRH1YFZ hOYt1GODnaOIoXqkR4zorkPrYJfS6QoWvstTwHSy3hSvgAEx/++4D5X1/lAo0dRGBqJc jIsw/HNrBBTdCuTvXJPsBv3B7DKq45wjMZ2TV2y34gT0Y2kljWeZKp1Q41ng7P7bCk4D HnsuGS5IwE8GF8ZF1dEm4r3WJ1qjfqKCwE07u2MtmRMtn0cFhlGlFMf5P2id7xXQ/dp4 Ihn9WDGv1KFi5DIFgbz+F0hF2ux6gNhvXep9S6mKnpDdhnGco5JzSZc9eWovdxQ7jjNE BgmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=wmE93zq4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id op24si9803372ejb.278.2021.05.16.02.52.18; Sun, 16 May 2021 02:52:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=wmE93zq4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231387AbhEOXxc (ORCPT + 99 others); Sat, 15 May 2021 19:53:32 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:42222 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230102AbhEOXx2 (ORCPT ); Sat, 15 May 2021 19:53:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=RP7yGAEHZlhCRQ2Dd9FV88IXokX2WkuH4I1RMy1fDuA=; b=wmE93zq4qsXp62qUP9gyku4vin jJZ5XJx3eBfJfB1dYbWETZylRioIp9dgyqQsatqaSCftXhIU4+HTdr5eDsZIio8viOBLMjJW05pga sL60/Bdj4Qad7tSdU6eqXm+8M6pzA8wYotI/wVs0c1O2IT7szUa5hsEBbwvqoj+BZhgo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1li44j-004NOO-Q4; Sun, 16 May 2021 01:52:05 +0200 Date: Sun, 16 May 2021 01:52:05 +0200 From: Andrew Lunn To: Ansuel Smith Cc: Jonathan McDowell , Florian Fainelli , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next v4 01/28] net: mdio: ipq8064: clean whitespaces in define Message-ID: References: <20210508002920.19945-1-ansuelsmth@gmail.com> <20210515170046.GA18069@earth.li> <20210515180856.GI11733@earth.li> <20210515194047.GJ11733@earth.li> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > They're on 2 separate sets of GPIOs if that makes a difference - switch0 > > is in gpio0/1 and switch1 is on gpio10/11. Is the internal MDIO logic > > shared between these? Also even if that's the case it seems odd that > > enabling the MDIO for just switch0 doesn't work? > > > > The dedicated internal mdio on ipq8064 is unique and present on the > gmac0 address so yes it's shared between them. And this seems to be the > problem... As you notice the fact that different gpio are used for the > different switch fix the problem. So think that to use the dedicated > mdio bus with both switch we need to introduce some type of > syncronization or something like that. Please could you describe the hardware in a bit more details. Or point me at a datasheet. It sounds like you have an MDIO mux? Linux has this concept, so you might need to implement a mux driver. Andrew