Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1747338pxj; Sun, 16 May 2021 02:59:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKsjNk5HIa56iSGTaIrKuAw0ATB8Ft1gg6UiqfbWJgAS6KiUfj0+uyHIdIslj1RL3iHpva X-Received: by 2002:a17:907:3e9a:: with SMTP id hs26mr29097165ejc.403.1621159149755; Sun, 16 May 2021 02:59:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621159149; cv=none; d=google.com; s=arc-20160816; b=umA3/GiOxc9MKCNGGzUlahCx3Tz1xAGP3C8PpCyYwfcwSNUSyIvha9tqQQ5ZRkKst1 mevXFqmq83EMWWvLsNwK4heXw/TyaTRefW12VsvTqBY8z+oN1IjFxkv3bD4HewA66Y9/ UwC17jF/jTiLLC3bVE1vv1A+PpQaxg6d/+8Ykp769UsDUsYB7MB8n9QWHvHa/qyZCMAl G218POsBr1Fc2nfdw6gSfC2azRIUnZ2gPyGRwxuuCQ/tMyYUP/XbnOA098RAyc0hiZR+ LBvberMewObn4cfSuT7gLQu61tiKLyYPD8h7iZx51GjCNBBA+aTGdUVy4QBXDhB8wTHN +MkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=9TYqCCSynqri8C7dKo0bKM9ZbaErPNXEaGInGQ35scc=; b=k5pm8UHfPn7KY097pJ5WFe1Zs9Yx0WbrCHp0hTxFSzMcP0l0ejzVsMmndrZ+i62tYy 4WDDhLVOSlfT1mzqDTzLFIczHxF56I5orpf9scAZAqKEMmXg37flX849vlXdyck/tDqV q4isySpU7tH98+wIUJa6G1sixODt9vCWjYXS3xJazbP+mZyQ8IFQMDFT40LU0MWDQxgC UIgqHvOtkXfzaR2kw1ll9sShFbY+NvAHfwU+aXLRjWReiopJG6VQ7+4YB6NOHeK6yngH 2O7zsFIzbyfoyDbGQfaofQwWNweMZisXYaX4lxACr8yP1SBzsSaEx/a86On4TUvNB+sQ wQYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gw24si10702415ejb.372.2021.05.16.02.58.46; Sun, 16 May 2021 02:59:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232233AbhEPCkW (ORCPT + 99 others); Sat, 15 May 2021 22:40:22 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2667 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229983AbhEPCkV (ORCPT ); Sat, 15 May 2021 22:40:21 -0400 Received: from dggems706-chm.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FjRFl0ljszNxFf; Sun, 16 May 2021 10:35:39 +0800 (CST) Received: from dggema769-chm.china.huawei.com (10.1.198.211) by dggems706-chm.china.huawei.com (10.3.19.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Sun, 16 May 2021 10:39:05 +0800 Received: from [10.174.179.215] (10.174.179.215) by dggema769-chm.china.huawei.com (10.1.198.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Sun, 16 May 2021 10:39:05 +0800 Subject: Re: [PATCH -next] ASoC: soc-core: use DEVICE_ATTR_RO macro To: Mark Brown CC: , , , , , References: <20210514081100.16196-1-yuehaibing@huawei.com> <20210514122442.GA6516@sirena.org.uk> From: YueHaibing Message-ID: Date: Sun, 16 May 2021 10:39:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210514122442.GA6516@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggema769-chm.china.huawei.com (10.1.198.211) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/14 20:24, Mark Brown wrote: > On Fri, May 14, 2021 at 04:11:00PM +0800, YueHaibing wrote: > >> -static ssize_t pmdown_time_set(struct device *dev, >> - struct device_attribute *attr, >> - const char *buf, size_t count) >> +static ssize_t pmdown_time_store(struct device *dev, >> + struct device_attribute *attr, >> + const char *buf, size_t count) > > This unrelated formatting change should be in a separate patch. This change pmdown_time_set() to pmdown_time_store(), which trigger checkpatch warning. >