Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date:   Sun, 16 May 2021 09:52:06 +0200
From:   Ingo Molnar <mingo@kernel.org>
To:     "H. Peter Anvin" <hpa@zytor.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] x86/syscall: update and extend selftest
 syscall_numbering_64
Message-ID: <YKDPJum3pB/Ma9Gs@gmail.com>
References: <20210515011015.2707542-1-hpa@zytor.com>
 <20210515011015.2707542-3-hpa@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210515011015.2707542-3-hpa@zytor.com>
Precedence: bulk


* H. Peter Anvin <hpa@zytor.com> wrote:

> From: "H. Peter Anvin (Intel)" <hpa@zytor.com>
> 
> Update the syscall_numbering_64 selftest to reflect that a system call
> is to be extended from 32 bits. Add a mix of tests for valid and
> invalid system calls in 64-bit and x32 space.
> 
> Use an explicit system call instruction, because we cannot know if the
> glibc syscall() wrapper intercepts instructions, extends the system
> call number independently, or anything similar.
> 
> Use long long instead of long to make it possible to compile this test
> on x32 as well as 64 bits.
> 
> Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
> ---
>  .../testing/selftests/x86/syscall_numbering.c | 274 ++++++++++++++----
>  1 file changed, 222 insertions(+), 52 deletions(-)

Small request: I'd suggest moving this to the first place - so that we can 
easily test before/after effects of (current) patch #1/4.

Thanks,

	Ingo