Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2339475pxj; Sun, 16 May 2021 22:48:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGlQ6AQcQ/uIapiacr8Vwag9iVcZxF0jiZY5Dvtn0WdO0UOhFCXeY2ZuebEDGFCj6zpDPS X-Received: by 2002:a05:6402:883:: with SMTP id e3mr17025870edy.1.1621230511466; Sun, 16 May 2021 22:48:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621230511; cv=none; d=google.com; s=arc-20160816; b=EB+zgTRlgGFo/htNNeHoMMtBtREqQEKQVEYW5w1mcUyU51RyjSiZ5LZT7f+BLS9M7l NiDTZIpbJkmiPCMsK0gcFvnBA0j2PT6nBqQtHW3MomYuqGyPuzDtv/a0XLkrfIzxgyt4 wevwUrT2bKG5S6VMdCt4rPUngcpsCXwASdmOLkVnSoGK5BSZ+EMuMnA/JTifrk8KCmbe OQcc3N41WlTGgXqzka9NHGDPkHfmzmc9eyVDZZeC/CHbvhh+aayulU35aqX0WfITse1h yk/PR5zgjc92wG9W7MIEHSwu0tj9lqxvP1r4gXOgmAn2R84m5SK9En6kvxhahQfcbh5J 21rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=4LsPAbMJd+IqOKQv3+Gf63mGt6dOG7rzjzIjevXmu6I=; b=lMy1ANjoamzC8fRt1KiEzD1Xd9HDWP/QpdbktBdfUV1Cr+Kg9JSczz+k95DufAVY3h El8+kUw9Z4tOgQEaKI59lP4JwSQpUWrfOjvhIuzEgiCcEW1xdF9fm/2niDMFMmzd3R8p gYoOTxPBpNiENtihOBkzbb8FsH56CTMWGK1eSQeHbqbrIbVyYd/CQrom9JyYO5kesth9 YRwcib+V+Fby/k05OUTBngZqv/zyJpiSKPuNMvsC3Elylyc7oWf4afktGhX7HWuJLVkW /1k3KmwfCWCzCuIPwaxaS98OUmt7SIOTWCRrTmkTh5PqKbeEDHU7R5BIyuk4OylVt+xn hK5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="GjyCS/ML"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w13si14042525edx.449.2021.05.16.22.48.09; Sun, 16 May 2021 22:48:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="GjyCS/ML"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230527AbhEQAzi (ORCPT + 99 others); Sun, 16 May 2021 20:55:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230075AbhEQAzi (ORCPT ); Sun, 16 May 2021 20:55:38 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1A30C061573; Sun, 16 May 2021 17:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=4LsPAbMJd+IqOKQv3+Gf63mGt6dOG7rzjzIjevXmu6I=; b=GjyCS/ML7yyMOTL6pct57ceADl GsFzQhlU54ewVFxjYO63Ud6vL3KsaaoJJxuVzAFSSfiGKGqEV2QRq+XHP4/d6ysprtBpwdKITslGl hfhvBCWJLc5ekfRMwG4XC9uKyTEfTIx/jm0EzY+sDZgmc+2AV5EU5rmIZgRvkAu3vF9kUc5U/VYnw GhcsHsXN2Gumt+Y+nzTiizvYYh7mAfjMPLk3w6U2NqbeA+dLEHgvRrqRJgeaX279P0XyM+LV2WDtX vq7Zknlh7OgwqwgSOe8YnBMeqbOmRsHvjYRZLjhA34NYXkA2puxNgkAJeyoiK+Ga0oneYoJjKreAs GMO1CcWA==; Received: from [2601:1c0:6280:3f0::7376] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1liRWV-00DOYA-9o; Mon, 17 May 2021 00:54:19 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Guenter Roeck , Wim Van Sebroeck , John Crispin , linux-mips@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: [PATCH] MIPS: ralink: export rt_sysc_membase for rt2880_wdt.c Date: Sun, 16 May 2021 17:54:17 -0700 Message-Id: <20210517005417.18338-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rt2880_wdt.c uses (well, attempts to use) rt_sysc_membase. However, when this watchdog driver is built as a loadable module, there is a build error since the rt_sysc_membase symbol is not exported. Export it to quell the build error. ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined! Fixes: 473cf939ff34 ("watchdog: add ralink watchdog driver") Signed-off-by: Randy Dunlap Cc: Guenter Roeck Cc: Wim Van Sebroeck Cc: John Crispin Cc: linux-mips@vger.kernel.org Cc: linux-watchdog@vger.kernel.org --- or make the Kconfig symbol RALINK_WDT bool instead of tristate? arch/mips/ralink/of.c | 2 ++ 1 file changed, 2 insertions(+) --- linux-next-20210514.orig/arch/mips/ralink/of.c +++ linux-next-20210514/arch/mips/ralink/of.c @@ -8,6 +8,7 @@ #include #include +#include #include #include #include @@ -25,6 +26,7 @@ __iomem void *rt_sysc_membase; __iomem void *rt_memc_membase; +EXPORT_SYMBOL_GPL(rt_sysc_membase); __iomem void *plat_of_remap_node(const char *node) {