Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2403461pxj; Mon, 17 May 2021 00:21:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAvn0xAlPGsjdd7TC9zG9RiMW1viuxwy5wNgDVguE6qZoj1cH+Pj9qX1voyJNxs+QJVLeG X-Received: by 2002:a92:dcc6:: with SMTP id b6mr23089758ilr.224.1621236113101; Mon, 17 May 2021 00:21:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621236113; cv=none; d=google.com; s=arc-20160816; b=yzP+P8QcO9LNctAMH6Fw6vK5b3SNfEJUaEF/0ibAL5/cmiEXr+Nep+GUmBYVvEfyn6 9y0Uj9gi0Ya0jxvBtr9Re8wV+6kRETMZihH6NomhHC2LXkZhvQtbjejCCVxGB3m/+52U uIrN4zO8s1U+L85OsqvX0rQP6gjY3j/0dPPsidtmrYWOHLZt1bEcsjhyEW25XwTS50Xj twjoYsgHvDSfYXJ+xWJmTorPevN+62LQqBCzUcYRmn7DIdoPIGt+EiU30Gzco+PpOVQA uP5hF6E5+6LnllbHjhim94pIFJykKYmPyAT9skE7bjni7EqldrfBe85za5vDCbXFUvFQ GctA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=nDBu6zljrONgTrZcq+JJSEWnvBueVDP0K2/MVFPLT+4=; b=T0w48BsrbO6S0Il/3hjNq6C2BbW5hUsp9qbc4InbxNf/NYmCXUVnlmTf/F6XENj2rF nzU0UajJNF6blRiwusgdOjxl0F0o1niLmolgPJfoEGtrpkG5HDysKqzbLAL6y51QjH6V 6zgszNVCV82D5h4GUql+fTXc4Dzg7EfzPp0jqmFABODhBiJ2k6WEbIlBmKdhVnQOC0lJ yRDA0mapJGNMVVdyR2x12z9+afO5Np+4s5HYhX5MvpJR0mtOQTuPQMiMbPPWmKG7g2L/ wzM288SYaghtdfDG2XbdwSDVqfnsulnud8Hzi+heQXiU28JwIEi3cFQwWJ5PT1OU4oBS 2TcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si7368427ilk.127.2021.05.17.00.21.40; Mon, 17 May 2021 00:21:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230339AbhEQF6v (ORCPT + 99 others); Mon, 17 May 2021 01:58:51 -0400 Received: from muru.com ([72.249.23.125]:56466 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229948AbhEQF6u (ORCPT ); Mon, 17 May 2021 01:58:50 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id C7C8980CE; Mon, 17 May 2021 05:57:37 +0000 (UTC) Date: Mon, 17 May 2021 08:57:30 +0300 From: Tony Lindgren To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, Haojian Zhuang , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 2/2] pinctrl: single: set pinmux from pins debug file Message-ID: References: <20210516135531.2203-1-dariobin@libero.it> <20210516135531.2203-3-dariobin@libero.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210516135531.2203-3-dariobin@libero.it> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Dario Binacchi [210516 13:55]: > @@ -331,6 +348,9 @@ static const struct pinctrl_ops pcs_pinctrl_ops = { > .get_group_name = pinctrl_generic_get_group_name, > .get_group_pins = pinctrl_generic_get_group_pins, > .pin_dbg_show = pcs_pin_dbg_show, > +#if IS_ENABLED(CONFIG_DEVMEM) && IS_ENABLED(CONFIG_SOC_AM33XX) > + .pin_dbg_set = pcs_pin_dbg_set, > +#endif > .dt_node_to_map = pcs_dt_node_to_map, > .dt_free_map = pcs_dt_free_map, > }; I don't think there should be any CONFIG_SOC_AM33XX dependency here? Regards, Tony