Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945991AbWJZXeA (ORCPT ); Thu, 26 Oct 2006 19:34:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1945993AbWJZXeA (ORCPT ); Thu, 26 Oct 2006 19:34:00 -0400 Received: from rgminet01.oracle.com ([148.87.113.118]:46916 "EHLO rgminet01.oracle.com") by vger.kernel.org with ESMTP id S1945991AbWJZXeA (ORCPT ); Thu, 26 Oct 2006 19:34:00 -0400 Message-ID: <45414644.5050802@oracle.com> Date: Thu, 26 Oct 2006 16:35:32 -0700 From: Randy Dunlap User-Agent: Thunderbird 1.5.0.5 (X11/20060719) MIME-Version: 1.0 To: Randy Dunlap CC: Roland Dreier , Andrew Morton , iss_storagedev@hp.com, lkml Subject: Re: [PATCH cciss: fix printk format warning References: <20061023214608.f09074e9.randy.dunlap@oracle.com> <20061026160245.26f86ce2.akpm@osdl.org> <454144ED.4020101@oracle.com> In-Reply-To: <454144ED.4020101@oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 36 Randy Dunlap wrote: > Roland Dreier wrote: >> > > if (*total_size != (__u32) 0) >> > > Why is cciss_read_capacity casting *total_size to u32? >> >> It's not -- it's actually casting 0 to __32 -- there's no cast on the >> *total_size side of the comparison. However that just makes the cast >> look even fishier. >> >> - R. > > OK, how about this one then? > > > c->busaddr = (__u32) cmd_dma_handle; > > where cmd_dma_handle is a dma_addr_t (u32 or u64) > > and then later: > > pci_free_consistent(h->pdev, sizeof(CommandList_struct), > c, (dma_addr_t) c->busaddr); > One problem with this one is that it looks like the hardware wants a 32-bit value for busaddr: cciss.h: writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET); -- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/