Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2427832pxj; Mon, 17 May 2021 01:00:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtcuyb7tEQpafooHacm++xszN1X5khp0d15Y76EIb64bvyXZJkHOfCq+JW1W5V71gAsVyb X-Received: by 2002:aa7:c04e:: with SMTP id k14mr33554405edo.157.1621238450119; Mon, 17 May 2021 01:00:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621238450; cv=none; d=google.com; s=arc-20160816; b=RbFvlHeiKHzx5PACpi6ygOdEKvEWXg6gwkMbQdhgO7lW635nMKEhB3Rs5WmhEp+bn4 Qiagg8dv4k4Q9aU1ZGf/zIJcxCj8oo37ZwH4WoHWpD4GSHcqXwcNpZQHrkZlP/6VV9l+ XBJz1Z3rXqe1RKBjBLVep7g/w4M5KMG2r6ysymjJ23rMSIsixXvoq9LUj6pZOhmYh6UX qhyRe9PWZ8Q8gArVr8hePkeW/kbF4kxP/pOIbMimi36eAWSbp0HAdD1+tOS+tHg3aq+f O/jh1CjjF1F7TfjhmTyuhxEkLVPso3m6AuKwxh3QYxttC0BoMknJl5CqUAS8XBJUwaar wXCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=vT6tVfgVQYax85ltv/yac9IUk/uA4vEprh4TNBKtlVo=; b=n+q1sYCJHn53GYKJT6gBOZ19XKuEGjtMuUMO7S8ZzUEvM+YzaYn57Z/puxrbSEWv/g bPz2QeGOdenX2HEorXAQAUmYWMXKwPjenUk1QF3wICp/M6gGNoz1V1N2J5XmielzncmK G3RdyFizpjgW/XPydU/o8tjCRZrYg68NX8QAFLlR6i6Rq8wHd7U6C+xVKXfDyh94pPkU 5vP7qAK6IrjN3ZZ25+g4s1nOdeXCqIF5YsXr0sz4hNdZuh4TlisrnP9YLjcPDf6u6U0G TP5PJASWBjTtKcEyUiK7zWBdsZQZfumBWG/9Ibws/p0PbYniGj+T9JS4HPB1cvYPe1PH SH5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oEJ+FkzC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z8si18251884edb.86.2021.05.17.01.00.27; Mon, 17 May 2021 01:00:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oEJ+FkzC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233996AbhEQHvu (ORCPT + 99 others); Mon, 17 May 2021 03:51:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229755AbhEQHvq (ORCPT ); Mon, 17 May 2021 03:51:46 -0400 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6558C061573; Mon, 17 May 2021 00:50:29 -0700 (PDT) Received: by mail-ot1-x333.google.com with SMTP id q7-20020a9d57870000b02902a5c2bd8c17so4813234oth.5; Mon, 17 May 2021 00:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vT6tVfgVQYax85ltv/yac9IUk/uA4vEprh4TNBKtlVo=; b=oEJ+FkzCAYVGNQuUH4qv+SoSmQPSANTJf31/FDy0Tb/92Bkg68SJQLBekz+JLd1ptU iGM9CKiH6/1gStpkopD39bEMw3X29dDPRQ0lYxa1BVpl4fXvCc8BKM9bC1DImzt2MbMx IzBCRq7CaNqntGWV4NNPoPPs2DmreKlrFcuZjE2vTaBr00gJDgcPbf7SCa+9vT5dExfU Nhsvm1SPzWFGUFvBcF9B3YGDQZc7vAHyX4RX/tH5jsaBj5osntfjhXUbqq6mML6szy00 xGYXwxEGh7hQ9R/UdOHEEkFqWgYbutRS078EH9uRdo2fb88NT6Q1ca+JTMiefNOFFzFm FtVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vT6tVfgVQYax85ltv/yac9IUk/uA4vEprh4TNBKtlVo=; b=mZ9EGLSPugxA0MLuu48GXzbjkaBghYRxq7WlLjdlty4ow50dVLOjYkSdp0NPy8Ajek UW82o91srAPWk5eFu6eYUYAg6zcAhFQQeEekyNtlPhbohd+ACOqBgyVBe4RpSwJuCYJY ZRqsnBYM8quOf7r74lRmah13DM69xrnEZMIlL/KjsC0jMPTbI4RLPK5sXGVvGVRtIhh8 Wq9QNNBM1kYjY2dzNe8ElVhplODGQJSD1JUZ+J8oA5j1PoFuSuCTP53M33kNcnUg4WuT 4S0j9psN+WsoFt//ljyTNnIg5j22pufaN1bPM6+LRP2UOtTCXTmqU+78iH6BfnsCr5le KdoA== X-Gm-Message-State: AOAM5313pYZ7qMr9MwZyKN0vRmcIEuE2+Icvkrw+lX76ntDW9wvbioJV xLkI8cyLhUXRRLSk0nm2Yn3axS7+LzJS6pYwD9U= X-Received: by 2002:a05:6830:1510:: with SMTP id k16mr35262204otp.290.1621237829236; Mon, 17 May 2021 00:50:29 -0700 (PDT) MIME-Version: 1.0 References: <20210517000108.26015-1-rdunlap@infradead.org> In-Reply-To: <20210517000108.26015-1-rdunlap@infradead.org> From: Manuel Lauss Date: Mon, 17 May 2021 09:49:53 +0200 Message-ID: Subject: Re: [PATCH] MIPS: alchemy: xxs1500: add gpio-au1000.h header file To: Randy Dunlap Cc: LKML , Thomas Bogendoerfer , Linux-MIPS , Ralf Baechle Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, May 17, 2021 at 2:01 AM Randy Dunlap wrote: > > board-xxs1500.c references 2 functions without declaring them, so add > the header file to placate the build. > > ../arch/mips/alchemy/board-xxs1500.c: In function 'board_setup': > ../arch/mips/alchemy/board-xxs1500.c:56:2: error: implicit declaration of function 'alchemy_gpio1_input_enable' [-Werror=implicit-function-declaration] > 56 | alchemy_gpio1_input_enable(); > ../arch/mips/alchemy/board-xxs1500.c:57:2: error: implicit declaration of function 'alchemy_gpio2_enable'; did you mean 'alchemy_uart_enable'? [-Werror=implicit-function-declaration] > 57 | alchemy_gpio2_enable(); > > Fixes: 8e026910fcd4 ("MIPS: Alchemy: merge GPR/MTX-1/XXS1500 board code into single files") > Signed-off-by: Randy Dunlap > Cc: Thomas Bogendoerfer > Cc: linux-mips@vger.kernel.org > Cc: Manuel Lauss > Cc: Ralf Baechle > --- > arch/mips/alchemy/board-xxs1500.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20210514.orig/arch/mips/alchemy/board-xxs1500.c > +++ linux-next-20210514/arch/mips/alchemy/board-xxs1500.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include Acked-by: Manuel Lauss Thank you! Manuel