Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2519237pxj; Mon, 17 May 2021 03:37:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyISnujXtK7T2QNqNs+BdMlRIpPcZqP50F6A5CqoX5SjNArF6RrYtRdZ6S24qNaJvOf8mkA X-Received: by 2002:a5e:dd47:: with SMTP id u7mr38135673iop.62.1621247868472; Mon, 17 May 2021 03:37:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621247868; cv=none; d=google.com; s=arc-20160816; b=Iig82fzbRdVNNZTLfLXCGVthXH6YTPaQRTo4S15F3cgKNSWnpnw9Lj8QmMkuOfvOPV XGI2LYk6IMrMkHjoe5dQjSDnUgp3A2tEVij4Zk9TkFWdWksow0LsayYFtG+HTFgRrjYQ 4VAn+4spBcMOQOW4R/27BxvMcRkIcLYXqsoi9y9M3ET/R3RTVAmzLB07iHKv66cKDzhj J9d58XVavMiJAvf0uqy66tG2/318SIHv1PvYvW+sE68vX+Hk84B464WP2WPU9Nnw2P0u nTcjk020ar5LHPBvx0ZMfbaqz90klWZq5Lhuof4I+njjTamhEpsCoKce4GtpfOy9RkkT b9WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GJno2ceL8eS2mdXEZ4U0rnYfUKgbNSYDHbscXj5cV3c=; b=dx3dx0hwVorp6wJgJYyTqKq8hnKDdoHUc00uhyO+WgH9p5STsnWt/8JFS1japBxvSr S4DkPsUPUNkCJPV3o3eARgOb3JzHnIMHz9j+a8Y5yB4Xj0ZSSmMhqZ0jJ56XaaUcb0PL e/HdSYh8ZzUcRSnxVsZHGh9OHJMoV0aMT2PCNb0FpKJfjytaxvLxy6f0MM8UXXGDDwQ1 CcKzIbJFYg1ERChg3bsD3IenTvjlzcR6NkZZIn3dDIfUlfPC2hfjXssnkfgv97V9GCb/ l/wDzwVKUPGN3jRX0zOWCRDuFJ5rOQA8kLHvccgLsESVvbvbSHWK5tFkPzPmceFptarL DLoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qXqCwsqd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i1si17127085ilk.75.2021.05.17.03.37.35; Mon, 17 May 2021 03:37:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qXqCwsqd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236441AbhEQKh1 (ORCPT + 99 others); Mon, 17 May 2021 06:37:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:32822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236218AbhEQKh0 (ORCPT ); Mon, 17 May 2021 06:37:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 089D4611CA; Mon, 17 May 2021 10:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621247770; bh=wIbh01EGhpy2Glxz4BA0QU4Cr0YfmkGXDrZC8LNYWGI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qXqCwsqd4/oJdhAqwblyA+uVGI4d3ZMXTQW/UonB7RAz3WPMBgDKp3FjI/nSFW9TR g+S2/QyR4XcHbVz5d2tnjw8SSFL9JinR6gDRnOrSslyWR4+Tnylz4RFVWGBUCPafcV /I23a6mo5vHaPgyFtOELvXps7hbBBThmlO/LxSRM= Date: Mon, 17 May 2021 12:36:08 +0200 From: Greg KH To: Kai Ye Cc: linux-accelerators@lists.ozlabs.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, zhangfei.gao@linaro.org, wangzhou1@hisilicon.com Subject: Re: [PATCH] uacce: use sysfs_emit instead of sprintf Message-ID: References: <1621247137-42693-1-git-send-email-yekai13@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1621247137-42693-1-git-send-email-yekai13@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 17, 2021 at 06:25:37PM +0800, Kai Ye wrote: > Use the sysfs_emit to replace sprintf. That says _what_ you did, not _why_ you are doing this. What problem are you solving with this change? thanks, greg k-h