Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kathirav=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 17 May 2021 16:16:38 +0530
From:   Kathiravan T <kathirav@codeaurora.org>
To:     Robert Marko <robert.marko@sartura.hr>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: socinfo: Add remaining IPQ6018 family ID-s
In-Reply-To: <20210504114826.64376-1-robert.marko@sartura.hr>
References: <20210504114826.64376-1-robert.marko@sartura.hr>
Message-ID: <0870f5c7cadf86d102747ec4f3d1b77e@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-05-04 17:18, Robert Marko wrote:
> ID for IPQ6018 was previously added, but ID-s for rest of the
> family are missing.
> So, lets add those based on downstream driver.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>

Reviewed-by: Kathiravan T <kathirav@codeaurora.org>

Nit: May be you can add the IPQ6005(453) variant as well? or you want to 
add it later on need basis?

> ---
>  drivers/soc/qcom/socinfo.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index f6cfb79338f0..28bbc7a9227e 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -255,6 +255,9 @@ static const struct soc_id soc_id[] = {
>  	{ 351, "SDA450" },
>  	{ 356, "SM8250" },
>  	{ 402, "IPQ6018" },
> +	{ 403, "IPQ6028" },
> +	{ 421, "IPQ6000" },
> +	{ 422, "IPQ6010" },
>  	{ 425, "SC7180" },
>  	{ 455, "QRB5165" },
>  };

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member of Code Aurora Forum, hosted by The Linux Foundation