Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210504114826.64376-1-robert.marko@sartura.hr> <0870f5c7cadf86d102747ec4f3d1b77e@codeaurora.org>
In-Reply-To: <0870f5c7cadf86d102747ec4f3d1b77e@codeaurora.org>
From:   Robert Marko <robert.marko@sartura.hr>
Date:   Mon, 17 May 2021 12:48:42 +0200
Message-ID: <CA+HBbNEqr2AxvUNm_kVC2n5i2qvJipDZJWbCRFNQZCnM8+RuGg@mail.gmail.com>
Subject: Re: [PATCH] soc: qcom: socinfo: Add remaining IPQ6018 family ID-s
To:     Kathiravan T <kathirav@codeaurora.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, May 17, 2021 at 12:46 PM Kathiravan T <kathirav@codeaurora.org> wrote:
>
> On 2021-05-04 17:18, Robert Marko wrote:
> > ID for IPQ6018 was previously added, but ID-s for rest of the
> > family are missing.
> > So, lets add those based on downstream driver.
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
>
> Reviewed-by: Kathiravan T <kathirav@codeaurora.org>
>
> Nit: May be you can add the IPQ6005(453) variant as well? or you want to
> add it later on need basis?
Hi, I completely missed that one.
I will send a v2 with it then.

Regards,
Robert
>
> > ---
> >  drivers/soc/qcom/socinfo.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> > index f6cfb79338f0..28bbc7a9227e 100644
> > --- a/drivers/soc/qcom/socinfo.c
> > +++ b/drivers/soc/qcom/socinfo.c
> > @@ -255,6 +255,9 @@ static const struct soc_id soc_id[] = {
> >       { 351, "SDA450" },
> >       { 356, "SM8250" },
> >       { 402, "IPQ6018" },
> > +     { 403, "IPQ6028" },
> > +     { 421, "IPQ6000" },
> > +     { 422, "IPQ6010" },
> >       { 425, "SC7180" },
> >       { 455, "QRB5165" },
> >  };
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
> member of Code Aurora Forum, hosted by The Linux Foundation


-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr