Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2653990pxj; Mon, 17 May 2021 06:49:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzq8JVZy248a0tHof57O4juW5gLtmddoUFyRejTS1hlAepcD/dfcY+Ta2KsyXSUEuRcOlV3 X-Received: by 2002:a05:6402:cb8:: with SMTP id cn24mr75231edb.325.1621259379526; Mon, 17 May 2021 06:49:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621259379; cv=none; d=google.com; s=arc-20160816; b=wcthhDgZCWEEM2v5/pLfSl0r+bqc68dDD7cxGbTpE9L8D3UvYoMtYIrTccdrRNhGVK iFvKaUuEO0eWI+SGQc3LJRrN5ih5E+rLuGaGF/asalpMkgqFPfj4DH99/lIXSP8oFJ4j aw2OwU4fOaUwqUyR1n5pDYUBh9StyFBbTI6LUrq6ZKTAV6GbIDxeyMWtpwYaepHsETQR qLXNYoh97TJd8kRAohnmwvPFaMjUROqz3386Cr9jdaKgH+/t1G+q0rGiNxXCb7pdMKnX QJ6b3v0SUfLC9Vcp4iXJkgkHuanotdYES7mC5+M+14WVYq7hXgN0qZ3+B/RCDLr4zt7d N8VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=jVWP7XCc0EaYfhyWip05y4QeemLSDB9bfRWIpmDYeCI=; b=D6Gz2tNxg8oNLlbwMvostvGNXuYoDjymdYnyEkOk2FYERlK5181IJZfUzXRwMQSy6z sClk7WwlinxmdGJtck3zM/PAu7tuqdztDXZ3sx0M5o+i8VW82JEObkWPUZnWnBHSzzTq tD7d4stMYBe+25nU5S68fWy7RaPA66pxVObqE7lJVoba7J+K9KhtUHzhjXZe2Ai/5QO5 x7T+PYVVwt3QfDjmedMi08OsJBkFzFeLPW7V6SWf8lQ2CvkD+4/va/6z1OTyaN2aTahQ rpTUOxOyhrg/uWaIwG4ot/ceOh2Dnlc8F8SBiY7UtZ6xrotVOi1dsEsP4XVolyRJlETh piDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b="EEMd/Eh3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o6si17354936edi.480.2021.05.17.06.49.16; Mon, 17 May 2021 06:49:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b="EEMd/Eh3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235591AbhEQIdF (ORCPT + 99 others); Mon, 17 May 2021 04:33:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:47642 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235406AbhEQIdE (ORCPT ); Mon, 17 May 2021 04:33:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1621240307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jVWP7XCc0EaYfhyWip05y4QeemLSDB9bfRWIpmDYeCI=; b=EEMd/Eh3zs7HxqhXewUtQMWYG0tLqDvgMtoH/hWSfFRL3GEIYOz6IhEYFbCydesZ39T6b1 gFldNMJ/q2aCM0GCuseqCx/lRoW9L4g2RccvZLwt8ToJzrsnX1mDDdujFqZJo0R/wKrkZP c2jNJH0xvP2NIYdJ95hlCC+fGq3eUhs= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1DE55AF0E; Mon, 17 May 2021 08:31:47 +0000 (UTC) Message-ID: <1327a9251c74587670970baa0f662cd61006f576.camel@suse.com> Subject: Re: [PATCH] HID: usbhid: enable remote wakeup for mouse From: Oliver Neukum To: Qiang Ma , jikos@kernel.org, benjamin.tissoires@redhat.com, linux-usb@vger.kernel.org Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 17 May 2021 10:31:45 +0200 In-Reply-To: <20210517060145.32359-1-maqianga@uniontech.com> References: <20210517060145.32359-1-maqianga@uniontech.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, den 17.05.2021, 14:01 +0800 schrieb Qiang Ma: > This patch enables remote wakeup by default for USB mouse > devices. Mouse in general are supposed to be wakeup devices, but > the correct place to enable it depends on the device's bus; no single > approach will work for all mouse devices. In particular, this > covers only USB mouse (and then only those supporting the boot > protocol). > Hi, have you tested this? In my experience the issue with mice is that they wake up only when you press a mouse button, not when you move the mouse. Do we make a promise we cannot keep here? Regards Oliver