Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 5.10 160/530] arm64: dts: qcom: db845c: fix correct
 powerdown pin for WSA881x
To:     Pavel Machek <pavel@denx.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Sasha Levin <sashal@kernel.org>, bgolaszewski@baylibre.com,
        linus.walleij@linaro.org
References: <20210512144819.664462530@linuxfoundation.org>
 <20210512144825.099918971@linuxfoundation.org> <20210515081814.GA30461@amd>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <55d58470-f606-8c75-1f00-a2eb09314081@linaro.org>
Date:   Mon, 17 May 2021 09:46:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20210515081814.GA30461@amd>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

+ Adding Linus W and Bartosz to CC.

On 15/05/2021 09:18, Pavel Machek wrote:
> Hi!
> 
>> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>
>> [ Upstream commit c561740e7cfefaf3003a256f3a0cd9f8a069137c ]
>>
>> WSA881x powerdown pin is connected to GPIO1 not gpio2, so correct this.
>> This was working so far due to a shift bug in gpio driver, however
>> once that is fixed this will stop working, so fix this!
> 
> I don't see the correspoing update to the driver this talks about.
> 
> Do we have corresponding driver in 5.10 and was it fixed to match?

This corresponding gpio driver patch was submitted along with the 
original fix, however it looks like it was not picked up yet.

https://www.spinics.net/lists/linux-gpio/msg59264.html

Bartosz/Linus W, Do you want me to resend this?

--srini

> 
> Best regards,
> 									Pavel
> 
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> @@ -1015,7 +1015,7 @@
>>   		left_spkr: wsa8810-left{
>>   			compatible = "sdw10217201000";
>>   			reg = <0 1>;
>> -			powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>;
>> +			powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>;
>>   			#thermal-sensor-cells = <0>;
>>   			sound-name-prefix = "SpkrLeft";
>>   			#sound-dai-cells = <0>;
>> @@ -1023,7 +1023,7 @@
>>   
>>   		right_spkr: wsa8810-right{
>>   			compatible = "sdw10217201000";
>> -			powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>;
>> +			powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>;
>>   			reg = <0 2>;
>>   			#thermal-sensor-cells = <0>;
>>   			sound-name-prefix = "SpkrRight";
>