Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1620801955-19188-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1620801955-19188-1-git-send-email-zou_wei@huawei.com>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Mon, 17 May 2021 10:50:50 +0200
Message-ID: <CAG3jFyvfO0L3JczeWZVE7hbcxL9rw3ub7=nQ2H1nkYkmhZz4RA@mail.gmail.com>
Subject: Re: [PATCH -next] drm/bridge: lt9611: Add missing MODULE_DEVICE_TABLE
To:     Zou Wei <zou_wei@huawei.com>
Cc:     Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hey Zou,

On Wed, 12 May 2021 at 08:29, Zou Wei <zou_wei@huawei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/gpu/drm/bridge/lontium-lt9611.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index e8eb8de..29b1ce2 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -1215,6 +1215,7 @@ static struct i2c_device_id lt9611_id[] = {
>         { "lontium,lt9611", 0 },
>         {}
>  };
> +MODULE_DEVICE_TABLE(i2c, lt9611_id);
>
>  static const struct of_device_id lt9611_match_table[] = {
>         { .compatible = "lontium,lt9611" },
> --
> 2.6.2
>

This looks good to me, I've picked this change into drm-misc-next.

https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8d0b1fe81e18eb66a2d4406386760795fe0d77d9