Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 17 May 2021 14:57:04 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        tony.luck@intel.com, x86@kernel.org,
        Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH 00/25] AMD MCA Address Translation Updates
Message-ID: <YKJoICQzD/o7ZPBp@zn.tnic>
References: <20210507190140.18854-1-Yazen.Ghannam@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210507190140.18854-1-Yazen.Ghannam@amd.com>
Precedence: bulk

On Fri, May 07, 2021 at 03:01:15PM -0400, Yazen Ghannam wrote:
> Patches 1-24 do the refactor without adding new system support. The goal
> is to break down the translation algorithm into smaller chunks. There
> are some simple wrapper functions defined. These will be filled in when
> supporting newer systems. The intention is that new system support can
> be added without any major refactor. I tried to make a patch for each
> logical change. There's a bit of churn so as to not break the build with
> each change. I think many of these patches can be squashed together, if
> desired. The top level function was split first, then the next level of
> functions, etc. in a somewhat breadth-first approach.

No, that's great what you did and keeping each logical change in a
single patch is a lot easier on everybody involved.

Now, looking at this - and I know we've talked about this before - but:

umc_normaddr_to_sysaddr() is used only in amd64_edac.c.
amd_df_indirect_read() is used only by this function, so how about
moving both to amd64_edac, where they're needed and then doing the
refactoring ontop?

You can simply reuse your current patches - just change the file they
patch from

arch/x86/kernel/cpu/mce/amd.c

to

drivers/edac/amd64_edac.c

I went through te umc_... function and AFAICT, it doesn't need any core
MCE facilities so it should be just fine in EDAC land.

Or?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette