Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946264AbWJ0Jfx (ORCPT ); Fri, 27 Oct 2006 05:35:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946266AbWJ0Jfx (ORCPT ); Fri, 27 Oct 2006 05:35:53 -0400 Received: from tim.rpsys.net ([194.106.48.114]:41349 "EHLO tim.rpsys.net") by vger.kernel.org with ESMTP id S1946264AbWJ0Jfw (ORCPT ); Fri, 27 Oct 2006 05:35:52 -0400 Subject: Re: [PATCH, RFC/T] Fix handling of write failures to swap devices From: Richard Purdie To: Nick Piggin Cc: kernel list , Andrew Morton In-Reply-To: <4541C1B2.7070003@yahoo.com.au> References: <1161935995.5019.46.camel@localhost.localdomain> <4541C1B2.7070003@yahoo.com.au> Content-Type: text/plain Date: Fri, 27 Oct 2006 10:35:37 +0100 Message-Id: <1161941737.5019.100.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 780 Lines: 21 On Fri, 2006-10-27 at 18:22 +1000, Nick Piggin wrote: > This is the right approach to handling swap write errors. However, you need > to cut down on the amount of code duplication. I've just looked at this and there isn't that much code duplicated, just a couple of big comment blocks which make it look like that. Those sections are similar in spirit but have been modified to work under different circumstances. Having looked again, I don't think its worth trying to merge them as it will become too unreadable. Cheers, Richard - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/