Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3114015pxj; Mon, 17 May 2021 18:08:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxC6k18Kgq/nMcwTSusNjYdnMWbtg8Cpdrhx1ziIZYLx6KJ99ETBeurkxR7DLYHpT4RTOcO X-Received: by 2002:a17:906:a1c7:: with SMTP id bx7mr3116778ejb.401.1621300085062; Mon, 17 May 2021 18:08:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621300085; cv=none; d=google.com; s=arc-20160816; b=wSY4zW1swUxJfTPZP9OzFuCrxPGTX58+T8ZlOZe1PhZcpDcKuKqRbpFoBRXih2PRwr MOcuu0MYoOpRfavpJ3OCUghs8v/DR+TM3m6Hwy92XQf4zkmHmkifwXYnswb1g9Cq1Qm1 6XWaxOWHTz4AMNnv7wiKs7h35IvY5TqnjR9VE42is2AFlD6kgpa16OsJx32K6xX+RsFG uiNjmZNyKMBlG2ofkUwLI0+9ahTARdrQrPCFHkK8/XafDsgpIxEtRe7czcBLZBBMO3ym J+NX7eaHOhoOPSigePfQrzNnclywSk/5ALoyUMxNT1u4b6mxvpYCdMgMTrWff1u42dbq 7Khw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=l+6ryiKHsnOZrkZjGxnuHvx4Cycm+dsFfU/WqN/dQEA=; b=LurZon9P1oRbz3j5jhTQ28kNbojb46uz3TiAc6MZF+VX9owWE04LqcmvvFUxsFH96Q j1OnQFIVnjBVq6zb41C79qpXB3d5E6FvGIrRJEA85gD4qCbC31DNq/LkJ2z9sQA+lblO HOZSD9ZxRk29Mlj9QzzpJqshQMosJ438JPsackAeq3pQuO52zXOm+RzNc3rktpX0vcCw 7YoyQVX0aHEe32RfBtP+yBvP99dHQgWCXtjYKWtQpphxKl9ddNd4hY964KoAP4YjIevO BFOkHCfQwbJ3YRLkC8WZuBxwGLBo0aatIFo1jnsAmhbtuPyaNjDNOqhaImvxO7nYTQIa EEfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y13si16919584edc.322.2021.05.17.18.07.41; Mon, 17 May 2021 18:08:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240027AbhEQO3w (ORCPT + 99 others); Mon, 17 May 2021 10:29:52 -0400 Received: from mail-ot1-f45.google.com ([209.85.210.45]:47076 "EHLO mail-ot1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239122AbhEQOZd (ORCPT ); Mon, 17 May 2021 10:25:33 -0400 Received: by mail-ot1-f45.google.com with SMTP id d3-20020a9d29030000b029027e8019067fso5648028otb.13; Mon, 17 May 2021 07:24:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l+6ryiKHsnOZrkZjGxnuHvx4Cycm+dsFfU/WqN/dQEA=; b=ExG201ldsdxHPBKjiupK/lb24wVlqnpATJaaniyIlgTnsIvbVbX+WAIeNzFRO6utGF Douvp1lnVg8QsodNDqQVfCGCJtFGz5W8CvKZU5FA1zWiddwZZ9YJYs1nuBw3Y0mkq0LZ uG/XZXaSxlo+Ycp4XHZph5lT0ylFs02cUPHIktD1FKhqQoxYAD0i0QFzpZPCsrVdRc6W rdL+SF1poIoRFFN1GMvYUsnZlf3ogvvE8Lwi2EJ5uJxgc0cp+X4CU+cpmJabmsZFIw4q gvzgr6EO2+GcZ5Fva22ahXyyVxNeBZxOydPGha7CAPDrYAbJE0ZAERo4kt7LGozFLxSX DRpA== X-Gm-Message-State: AOAM530S95Gxk6czFg0v1S/7WdXrWzTjSnC0mbxaYYD9Voh+NSttwaRk mZOsS+qLVxb+C+lF1vzSKpVfuEBVIYS6lyX11qw= X-Received: by 2002:a9d:3bcb:: with SMTP id k69mr52530163otc.206.1621261456311; Mon, 17 May 2021 07:24:16 -0700 (PDT) MIME-Version: 1.0 References: <20210505132032.601097-1-alexander.deucher@amd.com> In-Reply-To: <20210505132032.601097-1-alexander.deucher@amd.com> From: "Rafael J. Wysocki" Date: Mon, 17 May 2021 16:24:05 +0200 Message-ID: Subject: Re: [PATCH] ACPI: PM: s2idle: Add missing LPS0 functions for AMD To: Alex Deucher Cc: amd-gfx list , ACPI Devel Maling List , "Rafael J. Wysocki" , Len Brown , Linux Kernel Mailing List , Hans de Goede , Prike Liang , Shyam Sundar S K , Marcin Bachry , Mario Limonciello Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 5, 2021 at 3:21 PM Alex Deucher wrote: > > These are supposedly not required for AMD platforms, > but at least some HP laptops seem to require it to > properly turn off the keyboard backlight. > > Based on a patch from Marcin Bachry . > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1230 > Reviewed-by: Hans de Goede > Signed-off-by: Alex Deucher > Cc: Marcin Bachry > Cc: Mario Limonciello > --- > > Resend with updated subject. > > drivers/acpi/x86/s2idle.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c > index 2b69536cdccb..2d7ddb8a8cb6 100644 > --- a/drivers/acpi/x86/s2idle.c > +++ b/drivers/acpi/x86/s2idle.c > @@ -42,6 +42,8 @@ static const struct acpi_device_id lps0_device_ids[] = { > > /* AMD */ > #define ACPI_LPS0_DSM_UUID_AMD "e3f32452-febc-43ce-9039-932122d37721" > +#define ACPI_LPS0_ENTRY_AMD 2 > +#define ACPI_LPS0_EXIT_AMD 3 > #define ACPI_LPS0_SCREEN_OFF_AMD 4 > #define ACPI_LPS0_SCREEN_ON_AMD 5 > > @@ -408,6 +410,7 @@ int acpi_s2idle_prepare_late(void) > > if (acpi_s2idle_vendor_amd()) { > acpi_sleep_run_lps0_dsm(ACPI_LPS0_SCREEN_OFF_AMD); > + acpi_sleep_run_lps0_dsm(ACPI_LPS0_ENTRY_AMD); > } else { > acpi_sleep_run_lps0_dsm(ACPI_LPS0_SCREEN_OFF); > acpi_sleep_run_lps0_dsm(ACPI_LPS0_ENTRY); > @@ -422,6 +425,7 @@ void acpi_s2idle_restore_early(void) > return; > > if (acpi_s2idle_vendor_amd()) { > + acpi_sleep_run_lps0_dsm(ACPI_LPS0_EXIT_AMD); > acpi_sleep_run_lps0_dsm(ACPI_LPS0_SCREEN_ON_AMD); > } else { > acpi_sleep_run_lps0_dsm(ACPI_LPS0_EXIT); > -- Applied as 5.14 material, thanks!