Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3115644pxj; Mon, 17 May 2021 18:10:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFXV8WpuNJ5Wkfc4Kc81Tfo3rUEi34ge5mSkWlEMraPvq0hV+obBuuutTYRNqfpqETa5zb X-Received: by 2002:a17:906:3e52:: with SMTP id t18mr3032072eji.521.1621300221831; Mon, 17 May 2021 18:10:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621300221; cv=none; d=google.com; s=arc-20160816; b=V05tTzGD++d8F643LKj0CWruDnkBOwzPLd2JCXRnwQtJ39mGSCCu/v2CZANw2aTJFM AF5eKC352jC/1SP3T+qPfspTMzxYDPtUG6h4zwZfQpukZqrki/hc7NE56x+oUsoHcgWi /sVZsauCBUvE5n1t2lngpYBc35baeEaMHszceh1A/tm6ad9gGJ4cDEkrVKBQo/d8ecYM aQA5EiRr2SlAg4ARVPAKj5pFMifTxJClLe/5dczldmuIsFas+k43YXFkeNnmgrsjU+zA QsuW+REeea/W9qhevcl4ZmYPGnRh2DNw98bDYmq4+851fqYyUpBC4qt+3QH15PATY5/a /9TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pop/7Bza+EWWFRiLRSrmOseB8/qJs+79DH2ANTwVs/0=; b=FlH9aBxOwoto8BYH/3sfAgPrpZOwBQESSvgQ+OokYjG+Tfv0nNO4KImKyi9OhlKO27 21Zsh3CYU7U+0GkpPKzNiEdGohDW1wj8RphdjAANAuDUSiRt0w79ZMSMuNGHAZbxrzxa 2EgU3Q/wBhSMJERNVhexmMPKrd6yJ2FUv6cATUulsm8E9ycuurtqmAhlVWjHMhfGzTR6 I7JbhNj/RwPjA2ZVp1NVRDf/qUfVOLf1qmMH83Dj+nwvwr5Q06No2VrufmRImupw4kko Im3VJEqIdR2/wDKSNjOFvCLd8U/R8+SUKoVtz/G1aVtWGCnyXJIgCxFdKwgJkwGjHu4e ocwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="ZQF/DWeY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de51si11659242ejc.406.2021.05.17.18.09.59; Mon, 17 May 2021 18:10:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="ZQF/DWeY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239431AbhEQOcj (ORCPT + 99 others); Mon, 17 May 2021 10:32:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:49734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239539AbhEQO0m (ORCPT ); Mon, 17 May 2021 10:26:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 93E4361377; Mon, 17 May 2021 14:13:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621260826; bh=//uHrG56ebviNhfGB9vNzCSMnJGamdFbAdENJw9EhWs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZQF/DWeYxTQCuyYGnISvIrMQc1SLvlHeXIl6OLcLT8r4+yqEia8AacOuaoiYWUUS8 HmUulMzKjdy426hzsAEHKpOgU9i0BNKiggI8hNxduORbjgwj0lSovR1OmjokWN4Psv djQrGch0DFtztUeqSktW7UzV5v4JHzgbuaHDMvrc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jaroslaw Gawin , Mateusz Palczewski , Dave Switzer , Tony Nguyen , Sasha Levin Subject: [PATCH 5.12 244/363] i40e: fix the restart auto-negotiation after FEC modified Date: Mon, 17 May 2021 16:01:50 +0200 Message-Id: <20210517140310.829547494@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517140302.508966430@linuxfoundation.org> References: <20210517140302.508966430@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jaroslaw Gawin [ Upstream commit 61343e6da7810de81d6b826698946ae4f9070819 ] When FEC mode was changed the link didn't know it because the link was not reset and new parameters were not negotiated. Set a flag 'I40E_AQ_PHY_ENABLE_ATOMIC_LINK' in 'abilities' to restart the link and make it run with the new settings. Fixes: 1d96340196f1 ("i40e: Add support FEC configuration for Fortville 25G") Signed-off-by: Jaroslaw Gawin Signed-off-by: Mateusz Palczewski Tested-by: Dave Switzer Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index 0e92668012e3..6f3b7e0faa13 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -1409,7 +1409,8 @@ static int i40e_set_fec_cfg(struct net_device *netdev, u8 fec_cfg) memset(&config, 0, sizeof(config)); config.phy_type = abilities.phy_type; - config.abilities = abilities.abilities; + config.abilities = abilities.abilities | + I40E_AQ_PHY_ENABLE_ATOMIC_LINK; config.phy_type_ext = abilities.phy_type_ext; config.link_speed = abilities.link_speed; config.eee_capability = abilities.eee_capability; -- 2.30.2