Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210511063835.7794-1-jhp@endlessos.org>
In-Reply-To: <20210511063835.7794-1-jhp@endlessos.org>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 17 May 2021 16:32:04 +0200
Message-ID: <CAJZ5v0hsNSpL+1ero_+pzz97Xz4UCwjBv7swg+3CAne7_OUKkQ@mail.gmail.com>
Subject: Re: [PATCH] ACPI / EC: Fix media keys not working problem on more
 Asus laptops
To:     Jian-Hong Pan <jhp@endlessos.org>
Cc:     "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        Chris Chiu <chris.chiu@canonical.com>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux@endlessos.org, Chris Chiu <chiu@endlessm.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 11, 2021 at 8:40 AM Jian-Hong Pan <jhp@endlessos.org> wrote:
>
> From: Chris Chiu <chiu@endlessm.com>
>
> More ASUS laptops have the _GPE define in the DSDT table with a
> different value than the _GPE number in the ECDT.
>
> This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
>
> Add model info to the quirks list.
>
> Signed-off-by: Chris Chiu <chiu@endlessm.com>
> Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
> ---
>  drivers/acpi/ec.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 13565629ce0a..e8c5da2b964a 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
>         DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>         DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
>         {
> +       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
> +       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +       DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
> +       {
> +       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
> +       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +       DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
> +       {
> +       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
> +       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +       DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
> +       {
> +       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
> +       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +       DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
> +       {
>         ec_honor_ecdt_gpe, "ASUS X550VXK", {
>         DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>         DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
> --

Applied as 5.14 material under a different subject ("ACPI: EC: Make
more Asus laptops use ECDT _GPE"), thanks!