Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp138464pxj; Mon, 17 May 2021 23:15:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/b63GHrN4NhstNctcghP9tNkEdQMGUrsmIoXJe8CRYct5kHtP02uDmt+QAtERVS7tt3k6 X-Received: by 2002:a17:907:960b:: with SMTP id gb11mr4347190ejc.123.1621318537192; Mon, 17 May 2021 23:15:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621318537; cv=none; d=google.com; s=arc-20160816; b=UUD2pKuWgwKkSbgQ1JP9O/rp/DR41cjzgvqFmU5lyl94adPNd51zonYKOR+ShWpfVj M/UDDbPGjSOsbi23Yj8yDV5Nxf0Hg5JUp9SIc5z8Nq44LN/bVCZZVABFS9prd2WNb9Tf V+/jhMMgDAUeGDQg1Wf40egiBadf5p08hE1CimOz1u48FkR/cChvZcuoHWEx/oxG2wkZ o6TtQlh2BQfdg9DdeYYWBBPclqhVunto3w52o+sSFjnokB31f4L6AeA/kcymD/LuEont eUG2SavjtZmW77PsZshqHVANh5Vy1A3cUd/j83DF2IEJ+AXu6I+ojSjwsLFXAi29usO/ Lz1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=nCTj6HgOq3kiS9EgLLQMGC5yw5m63tUFyLTYwxvC2gM=; b=LMROMVZkbS7Cr+8lYg/u/ivkf5l9QVDZ8QYGHoWfl6VaOMQKE+w51z5GXTw5qSUhk7 bzQrk9rBevTFHn9MLR9fbQIBlNsdAXB9FS8z9yTnNeo2OEdG4GV1vKnUMKzV5J4tjwUf YW6jrr/nYlLlmwRZSDgCzD2lulszKzcS2NDJsmv52/66N9BPuDnFblX6EvJvsmuQLuLi eWGMF4+gNohrctOXCJ9DDt5ftuayokUs6qfzzgENveFDQNSjFy6xfNDeLRycBohrCDJe jhHNQbncqtCrMUNF+9hB009onVUiui5nXURDFXENT6C6RTx3T1mEfonrfcNVRDbpuB5g m4Og== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z10si17417329edb.230.2021.05.17.23.15.13; Mon, 17 May 2021 23:15:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242024AbhEQOtk (ORCPT + 99 others); Mon, 17 May 2021 10:49:40 -0400 Received: from mail-oi1-f176.google.com ([209.85.167.176]:33670 "EHLO mail-oi1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240240AbhEQOll (ORCPT ); Mon, 17 May 2021 10:41:41 -0400 Received: by mail-oi1-f176.google.com with SMTP id b25so6737797oic.0; Mon, 17 May 2021 07:40:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nCTj6HgOq3kiS9EgLLQMGC5yw5m63tUFyLTYwxvC2gM=; b=tg/ev4ENmNbgBm7WLLIgJQAgYOEEE34Iq87uZnaHd5fTOKyuLCp9B66vK7EDa1NSWq lmKNHPMNinEzFgv5aRNLhcDylxPRaIBQR8lz03Nl91ca2XAwdNZCaF4gKvFp2b7SkuIp YyLMvIURBsmc1iSy02o3Qi4yjuYoGP8ObZ2B5idkRur3QcGboQTMUyp2/KodKkOCGA5M f7tRre17n2c4m1+ZuTENGJnoIRa7xL6ZJz1Vj1B4nLcXnlHy2dDLOs3OZ9XVwvKYj62y HTYYsfaDgIArSWj8rF4/TFQGow8AgXjIMrKUevLvhXxOjDcVqvvdgsw/aeSiWNzmm10g GH9w== X-Gm-Message-State: AOAM530j/9xREABeNu2QAtTjiPB36w/hJI2KBlVMgTp7HP63+O2EpaaO dQQahwqFcuC9Uudw3PEFwJDsY8S826Hp2eMxIlc= X-Received: by 2002:aca:380a:: with SMTP id f10mr109907oia.157.1621262424289; Mon, 17 May 2021 07:40:24 -0700 (PDT) MIME-Version: 1.0 References: <20210511063835.7794-1-jhp@endlessos.org> In-Reply-To: From: "Rafael J. Wysocki" Date: Mon, 17 May 2021 16:40:13 +0200 Message-ID: Subject: Re: [PATCH] ACPI / EC: Fix media keys not working problem on more Asus laptops To: "Rafael J. Wysocki" Cc: Jian-Hong Pan , "Rafael J . Wysocki" , Len Brown , Chris Chiu , ACPI Devel Maling List , Linux Kernel Mailing List , linux@endlessos.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 17, 2021 at 4:32 PM Rafael J. Wysocki wrote: > > On Tue, May 11, 2021 at 8:40 AM Jian-Hong Pan wrote: > > > > From: Chris Chiu > > > > More ASUS laptops have the _GPE define in the DSDT table with a > > different value than the _GPE number in the ECDT. > > > > This is causing media keys not working on ASUS X505BA/BP, X542BA/BP > > > > Add model info to the quirks list. > > > > Signed-off-by: Chris Chiu > > Signed-off-by: Jian-Hong Pan > > --- > > drivers/acpi/ec.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > > index 13565629ce0a..e8c5da2b964a 100644 > > --- a/drivers/acpi/ec.c > > +++ b/drivers/acpi/ec.c > > @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = { > > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > > DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL}, > > { > > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", { > > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > > + DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL}, > > + { > > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", { > > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > > + DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL}, > > + { > > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", { > > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > > + DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL}, > > + { > > + ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", { > > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > > + DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL}, > > + { > > ec_honor_ecdt_gpe, "ASUS X550VXK", { > > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > > DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL}, > > -- > > Applied as 5.14 material under a different subject ("ACPI: EC: Make > more Asus laptops use ECDT _GPE"), thanks! And dropped, because the chiu@endlessm.com email address is bouncing. Please resend with a valid email address in the From: field, thanks!