Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp153471pxj; Mon, 17 May 2021 23:42:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypBeRqd4iprhINLfeNE3NndOsRyT52xHm7HICjqQzWN7Nmum0/BiHLWm/Vgibyspb3fSW0 X-Received: by 2002:a17:906:5917:: with SMTP id h23mr4505982ejq.457.1621320176279; Mon, 17 May 2021 23:42:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621320176; cv=none; d=google.com; s=arc-20160816; b=0Kl+JtSL3UvlrMWPKm3afhQ+9ofFfOobeiqXjH6dScuMxqDr8FkpR+C0uneY/L94fV Tp0/s2i+e32vEr8dTstFGnySRKpmZwLS7MYflrSZZ5sPKjouSn9QsvtnhNXsYpksn+Vi IYWoCxk7l8gWl5Wl02q7oZks0zc8U7bnpgHet5/3Fusf6YFsVlYnTnzEB76SvWD1UChR U6Ye2jHZGlA6ErBq0XAYPIRmG1A5F3wbBFjyfdTr3c6lFMr/QAql8vLFb2LPPu6UM/C5 /BBDZsrPmG19P9lLWUA846bCSqNHMEvyzSe/IMgnqDi/8GbjYaMDL4It1j3J7e6gLuuc 9FYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6G2+uy+xqfaNsHwgOpJEKMZjy2OKIBelJny39RpwDt8=; b=ZsX8qtD5l+8D5V7Xx6G/8eeoetTwuDjkM6Sk+x/Xckt5X7UBJbY+PHPV4j6IYPQDJ1 ipabQrz0zRx5D0gI0Hnm4SwrdSfcs6KD2SSk5PPirDyXRt4HC/Rj2Wxs3bhYJqRZ7c1z pVnMn4Vll/+g9SFV6J/fmxXBix5C/T1QUdPnO/jKdUT3xGE3WjmhymUDjXuD2xn19oa4 AHOVQipB2aUUtX0eD+Oq5qnOtDwwrpAwrJ2G5S6UDYif80YymyKTHTgipqjUnA9QuPnO 40pTaZCFsmgn+nNXLET0dNHJOtKDYpRR5D0/7D1Bv/h/4rXV22SC/WBe3+NeZOyvr/B4 bQvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zwKCgTQH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d19si15812519edj.451.2021.05.17.23.42.33; Mon, 17 May 2021 23:42:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zwKCgTQH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241507AbhEQOv4 (ORCPT + 99 others); Mon, 17 May 2021 10:51:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:52916 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239765AbhEQOk7 (ORCPT ); Mon, 17 May 2021 10:40:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1DB326194B; Mon, 17 May 2021 14:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621261139; bh=XmE/h6mxa1tGTjLYTwMQGr/iIbvAWN++PJsig3t2DFg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zwKCgTQHdo6ZnqHTW1rFJhkCue4qDuoSqDgEKEQ9vzG/W+d5l4koYB/IYyC7QOmcU 5dU50fvUboaggphD9HE9IFAeYCNT9vEv4SNCBUJbF6xWalq80z65QmhyDr2nursWQx 06nm/fmWv9WzFUAfvzdKgfYayZcsovvk0zTHd494= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Felipe Balbi , Zhen Lei Subject: [PATCH 5.12 313/363] usb: dwc3: imx8mp: fix error return code in dwc3_imx8mp_probe() Date: Mon, 17 May 2021 16:02:59 +0200 Message-Id: <20210517140313.190624227@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517140302.508966430@linuxfoundation.org> References: <20210517140302.508966430@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhen Lei commit 0b2b149e918f6dddb4ea53615551bf7bc131f875 upstream. Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 6dd2565989b4 ("usb: dwc3: add imx8mp dwc3 glue layer driver") Reported-by: Hulk Robot Acked-by: Felipe Balbi Signed-off-by: Zhen Lei Cc: stable Link: https://lore.kernel.org/r/20210508015310.1627-1-thunder.leizhen@huawei.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/dwc3-imx8mp.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/dwc3/dwc3-imx8mp.c +++ b/drivers/usb/dwc3/dwc3-imx8mp.c @@ -167,6 +167,7 @@ static int dwc3_imx8mp_probe(struct plat dwc3_np = of_get_child_by_name(node, "dwc3"); if (!dwc3_np) { + err = -ENODEV; dev_err(dev, "failed to find dwc3 core child\n"); goto disable_rpm; }