Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp153689pxj; Mon, 17 May 2021 23:43:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNww7v7YXKGtqkMHzr9RRAgq1YtUG0qUbMnsrdVA1ZqA7dy+le89bU9SIRhJ57IihEUraa X-Received: by 2002:a17:906:e210:: with SMTP id gf16mr4569641ejb.472.1621320199315; Mon, 17 May 2021 23:43:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621320199; cv=none; d=google.com; s=arc-20160816; b=tqEiZ0XnHmp7HCtiIOl0+nrPJWmRcmr2WjNAFpYb4GjpHA5w0HLwOKNaMLNOMfrU4n gi7a3JEOVlV65D+Q/rWH9Q2v4jOO9BD313BRA+7eKL3OC9xiTnRfrcc9TxmgIHgz9tzZ 47QvB2lnDVsOs7E51Q/41E/Blvu7eX2KWfpUNG/+/5YxHt87QK/3soAWlIeAJtjUfRAZ iGI/EJ0rhq+1r0Lnm2fnUzEUI0ByQb21MCf4mrSRZFjB/eVFlZHStX955Gq3O2eSuaKU 9W4OzCIBGin27xmN8GKc45/sPxvZub/i7xX/HzFE7cs/QEo7BG1Y92n2C1Wp7m1UKzKR yu5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XoUrV4fYwZ5eDEDZAHf3H74xJLKyFJUn2zbmzoXxggk=; b=kTacBXM+uUpfMGRFlydzDpiz/eI/vX20mY4RNVWVe4XoNq85hpyPEJOx7BQtE7S7TF paLD0oRjkQ/XeR4JpVFQIcEwRl5+51Ed8Xjpl0xtHK8ACyiApVOa0COG4c6NefCqw33J 51/FdnFBcUwC2GlSccwENy7n3a28EsbICc/H7dC4DprROGxyOhE9FA8a3Gu/gjTSEvGH koncVHTfdJJ7yyc3gJOpQxrBvoerL9ANSMhPCpW/S9KRet7z9vZXne7pRLh1WT9mmBcu 7NeiUPKo1D4vfO96Au8MV0viS8KPgnfyn3c1wQR9PVkZn7nVd4IDxYLucCynHbE5E/L0 TZAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ggvOE6MI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q13si16383310edw.142.2021.05.17.23.42.56; Mon, 17 May 2021 23:43:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ggvOE6MI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240072AbhEQOw3 (ORCPT + 99 others); Mon, 17 May 2021 10:52:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:50854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241312AbhEQOoW (ORCPT ); Mon, 17 May 2021 10:44:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 00CB76195D; Mon, 17 May 2021 14:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621261249; bh=l6JtpswOXURGtwYZ5hYYWOergdQEDDoc8UI/xd6dLdg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ggvOE6MI3mUtk8WoPYyY0/bkbHcnkSxwUV8hlodmm7jzIJI0DNzrXatnhmuGTnghr n+Jac7HTKRpdx5PFfL3PEx9d1tJm9J997fT/oKjUnH05TV3ZN+kg6xrmfEvh1S8GRf vFv/qUE8MO2HNoBdhDrwK7sfXulMeKAKmZn7qDBo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yaqi Chen , Alexei Starovoitov , Yonghong Song , Sasha Levin Subject: [PATCH 5.11 090/329] samples/bpf: Fix broken tracex1 due to kprobe argument change Date: Mon, 17 May 2021 16:00:01 +0200 Message-Id: <20210517140305.162467295@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517140302.043055203@linuxfoundation.org> References: <20210517140302.043055203@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yaqi Chen [ Upstream commit 137733d08f4ab14a354dacaa9a8fc35217747605 ] >From commit c0bbbdc32feb ("__netif_receive_skb_core: pass skb by reference"), the first argument passed into __netif_receive_skb_core has changed to reference of a skb pointer. This commit fixes by using bpf_probe_read_kernel. Signed-off-by: Yaqi Chen Signed-off-by: Alexei Starovoitov Acked-by: Yonghong Song Link: https://lore.kernel.org/bpf/20210416154803.37157-1-chendotjs@gmail.com Signed-off-by: Sasha Levin --- samples/bpf/tracex1_kern.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/bpf/tracex1_kern.c b/samples/bpf/tracex1_kern.c index 3f4599c9a202..ef30d2b353b0 100644 --- a/samples/bpf/tracex1_kern.c +++ b/samples/bpf/tracex1_kern.c @@ -26,7 +26,7 @@ SEC("kprobe/__netif_receive_skb_core") int bpf_prog1(struct pt_regs *ctx) { - /* attaches to kprobe netif_receive_skb, + /* attaches to kprobe __netif_receive_skb_core, * looks for packets on loobpack device and prints them */ char devname[IFNAMSIZ]; @@ -35,7 +35,7 @@ int bpf_prog1(struct pt_regs *ctx) int len; /* non-portable! works for the given kernel only */ - skb = (struct sk_buff *) PT_REGS_PARM1(ctx); + bpf_probe_read_kernel(&skb, sizeof(skb), (void *)PT_REGS_PARM1(ctx)); dev = _(skb->dev); len = _(skb->len); -- 2.30.2