Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of cadence.com designates
 158.140.1.147 as permitted sender) receiver=protection.outlook.com;
 client-ip=158.140.1.147; helo=sjmaillnx1.cadence.com;
X-CrossPremisesHeadersFilteredBySendConnector: maileu3.global.cadence.com
Received: from maileu3.global.cadence.com (10.160.88.99) by
 maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server (TLS) id
 15.0.1497.2; Mon, 17 May 2021 17:06:32 +0200
Received: from vleu-orange.cadence.com (10.160.88.83) by
 maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server (TLS) id
 15.0.1497.2 via Frontend Transport; Mon, 17 May 2021 17:06:32 +0200
Received: from vleu-orange.cadence.com (localhost.localdomain [127.0.0.1])
        by vleu-orange.cadence.com (8.14.4/8.14.4) with ESMTP id 14HF6Whd013255;
        Mon, 17 May 2021 17:06:32 +0200
Received: (from sparmar@localhost)
        by vleu-orange.cadence.com (8.14.4/8.14.4/Submit) id 14HF6WUn013254;
        Mon, 17 May 2021 17:06:32 +0200
From:   Sanket Parmar <sparmar@cadence.com>
To:     <peter.chen@kernel.org>
CC:     <pawell@cadence.com>, <a-govindraju@ti.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kurahul@cadence.com>, <gregkh@linuxfoundation.org>,
        <kishon@ti.com>, Sanket Parmar <sparmar@cadence.com>
Subject: [PATCH] usb: cdns3: Enable TDL_CHK only for OUT ep
Date:   Mon, 17 May 2021 17:05:12 +0200
Message-ID: <1621263912-13175-1-git-send-email-sparmar@cadence.com>
X-Mailer: git-send-email 2.4.5
MIME-Version: 1.0
Content-Type: text/plain
X-OrganizationHeadersPreserved: maileu3.global.cadence.com
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2c057d0c-a856-4aaa-80c4-08d919455d6e
X-MS-TrafficTypeDiagnostic: MWHPR07MB3584:
X-Microsoft-Antispam-PRVS: <MWHPR07MB35847EBD896987664A63A0FBB02D9@MWHPR07MB3584.namprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3383;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YeQi6jbuxJ9ab6V25wPz34rs/nz3HOleuPEsZUr8X8wv5AOpPFDuXD1QCjOmgtajzvSsr7WRFaPluu9TeC1+JlR9vOusBV7ZtQ/8jB0tN0f50KuQdnRFXUIJ68kT63uOsE+kGRrypv5ZDOyaCL8115c4750TovQGlFoyIWYhQVk5TsvvMItlsQ6N87RxiPJFPbjaKy3xSOynaa/RG7T54aaoWoS/FjZKnfux7A9QWcmmg+jDiLLH+EAVPRs5vgVHiELzljQE50K/XBrfYwEoYoqLnIfegA+gU2W0ABpKmVvjkDnSkjDCpZXfmp7a7DNhAfLu2ESqSkbDjbG++0SMN+powDu8tUX+vwea6C1jExKZCB6jpdaaWQ6XW3bLRL8SBnkIMGGPZZzD/YtbCk6mMOVrCMOg9lukAL2C15yOa1178jaKVIy2WuE2Qfgf0oUf03TWEb47cu+5yKil0Wv680BmW9YlQSHCi03Wts76rOwGdGxeZ45G57zJE67na5Hy2nWPfxfVgTIyR+wEBei6+TufwZ1N7Kw4l9scfUr7OK1GvLRabiCSNq/4qEyI0T0PP2+UHy4gCtn80Z672bDQy4MIftbuFibDrcPGeXFZYWXYzYylJruEnU0SOX9aAU3n0wjnWH/Anh5Y/KEG6o2hgg8yiFz+tjLaK/7hzUSr4fQNOfLA2lBU4cefojANCyyn
X-Forefront-Antispam-Report: CIP:158.140.1.147;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:sjmaillnx1.cadence.com;PTR:unknown.Cadence.COM;CAT:NONE;SFS:(4636009)(376002)(39850400004)(136003)(346002)(396003)(36092001)(36840700001)(46966006)(36756003)(26005)(82310400003)(186003)(47076005)(6916009)(42186006)(82740400003)(7636003)(5660300002)(83380400001)(478600001)(6666004)(8676002)(70586007)(70206006)(107886003)(36906005)(316002)(4326008)(2906002)(2616005)(426003)(336012)(36860700001)(54906003)(8936002)(86362001)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2021 15:06:35.9127
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c057d0c-a856-4aaa-80c4-08d919455d6e
X-MS-Exchange-CrossTenant-Id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d36035c5-6ce6-4662-a3dc-e762e61ae4c9;Ip=[158.140.1.147];Helo=[sjmaillnx1.cadence.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM12FT037.eop-nam12.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3584
X-Proofpoint-GUID: RsoMi486DUR4yMbVG-IfBtNNZrBFzJfK
X-Proofpoint-ORIG-GUID: RsoMi486DUR4yMbVG-IfBtNNZrBFzJfK
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-05-17_06:2021-05-17,2021-05-17 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 malwarescore=0
 mlxscore=0 priorityscore=1501 impostorscore=0 adultscore=0 bulkscore=0
 phishscore=0 clxscore=1011 mlxlogscore=938 suspectscore=0 spamscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2105170107
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

ZLP gets stuck if TDL_CHK bit is set and TDL_FROM_TRB is used
as TDL source for IN endpoints. To fix it, TDL_CHK is only
enabled for OUT endpoints.

Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
Reported-by: Aswath Govindraju <a-govindraju@ti.com>
Signed-off-by: Sanket Parmar <sparmar@cadence.com>
---
 drivers/usb/cdns3/cdns3-gadget.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
index 105855a..f3c0276 100644
--- a/drivers/usb/cdns3/cdns3-gadget.c
+++ b/drivers/usb/cdns3/cdns3-gadget.c
@@ -2007,7 +2007,7 @@ static void cdns3_configure_dmult(struct cdns3_device *priv_dev,
 		else
 			mask = BIT(priv_ep->num);
 
-		if (priv_ep->type != USB_ENDPOINT_XFER_ISOC) {
+		if (priv_ep->type != USB_ENDPOINT_XFER_ISOC  && !priv_ep->dir) {
 			cdns3_set_register_bit(&regs->tdl_from_trb, mask);
 			cdns3_set_register_bit(&regs->tdl_beh, mask);
 			cdns3_set_register_bit(&regs->tdl_beh2, mask);
@@ -2046,15 +2046,13 @@ int cdns3_ep_config(struct cdns3_endpoint *priv_ep, bool enable)
 	case USB_ENDPOINT_XFER_INT:
 		ep_cfg = EP_CFG_EPTYPE(USB_ENDPOINT_XFER_INT);
 
-		if ((priv_dev->dev_ver == DEV_VER_V2 && !priv_ep->dir) ||
-		    priv_dev->dev_ver > DEV_VER_V2)
+		if (priv_dev->dev_ver >= DEV_VER_V2 && !priv_ep->dir)
 			ep_cfg |= EP_CFG_TDL_CHK;
 		break;
 	case USB_ENDPOINT_XFER_BULK:
 		ep_cfg = EP_CFG_EPTYPE(USB_ENDPOINT_XFER_BULK);
 
-		if ((priv_dev->dev_ver == DEV_VER_V2  && !priv_ep->dir) ||
-		    priv_dev->dev_ver > DEV_VER_V2)
+		if (priv_dev->dev_ver >= DEV_VER_V2 && !priv_ep->dir)
 			ep_cfg |= EP_CFG_TDL_CHK;
 		break;
 	default:
-- 
1.7.1