Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp377285pxj; Tue, 18 May 2021 05:33:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQmxf6LD4LWkchS0ejp3f4xeCTp+B6CQPeAuKhBYOZ7cSFUQrw7UhZdN4WbedhhDFzhZ9z X-Received: by 2002:a17:906:36da:: with SMTP id b26mr5935708ejc.8.1621341203009; Tue, 18 May 2021 05:33:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621341203; cv=none; d=google.com; s=arc-20160816; b=jM2aJnhiWju1FTnWMGS70QGFJVe2gO7LbIhbQ8BpJkVCs7Qf+/+pBsjKVFh8MnshWi jbBJ3zeIDLNkR4vfjWuhD0JJ1mWFum2x8GYkuWSfqiQ+pmo/YueHXwNQJiSWIrj/09I2 XdQK9uzI/bk/EDyvkpdbk2u/P6KnLI1Q5TveK3VKn4CR6Wis/PBtyZnNObdhqeNSz4rw YrP6QE7zn4C9hRSy6EX20pGJwdaLscwCp7q8kdUl4W6i/q7wJtm/7Q3BRuxV583Y+/qY rSktilrY6m1hvU0L7W+4FA2U3LBV4TSoSXi1fmkPXsJ8qfw/1KeGxBESz2eJGOewewTM oysA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lnex/hWeoBdNYylnOElZCNlWPhIWen7Dfr0++yb4eZ0=; b=Tod/L5333GZeNRwVj7p4PJ9peHk03EwuaGkG3kiAR+g7ptuUx1PMRCb5flSpxxy/Jc UM2GzpZ4zQuobma6ALYCNYerJEySpInnx4oPKY58NZt5F0/yQ1681n0mUXGwc73y/PAT o66tzBtqfKbhxdrUBashiCWmbbyaCC1Pfwl3G7jYyGvuCp/OBWlgCYPxYk88Zyu/UPnu c34F76NrfSNqNLfgGGOAL/5IK9uRcNdka7Grc34ISLyShb2Dm/pc5uO0+JIqUMYI0+S+ cxIxCqBlBwqNT/OPAqqzxZfCJpA7LUblqn1EOWVgPnhEYZGUPZL7Crfj9l716SfZPwwB Khrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=m5NIPQbC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ak17si17351197ejc.442.2021.05.18.05.32.59; Tue, 18 May 2021 05:33:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=m5NIPQbC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245438AbhEQP3Z (ORCPT + 99 others); Mon, 17 May 2021 11:29:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:37254 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243715AbhEQPOg (ORCPT ); Mon, 17 May 2021 11:14:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5495361C61; Mon, 17 May 2021 14:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621261929; bh=QC5ha4TMX+jv+AkEVRdL8x+jfrSeuRBiUQl+af5vZ4c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m5NIPQbCF4/kVoG9rtFDFMsYMhGcvoiwJEsHhynyguDRcHssWldRDDFPrverxllpI EAgEMw9qaEv3h+SUrxTXlhKVlQu7+uDZC2zGEBTZsSujNi+sp5w9FlCXstYA7I7fP/ WDESngw7tjDYRG4BH1+ELIHo7KKHGWADbcCexsJk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jaroslaw Gawin , Mateusz Palczewski , Dave Switzer , Tony Nguyen , Sasha Levin Subject: [PATCH 5.4 093/141] i40e: fix the restart auto-negotiation after FEC modified Date: Mon, 17 May 2021 16:02:25 +0200 Message-Id: <20210517140245.901126130@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517140242.729269392@linuxfoundation.org> References: <20210517140242.729269392@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jaroslaw Gawin [ Upstream commit 61343e6da7810de81d6b826698946ae4f9070819 ] When FEC mode was changed the link didn't know it because the link was not reset and new parameters were not negotiated. Set a flag 'I40E_AQ_PHY_ENABLE_ATOMIC_LINK' in 'abilities' to restart the link and make it run with the new settings. Fixes: 1d96340196f1 ("i40e: Add support FEC configuration for Fortville 25G") Signed-off-by: Jaroslaw Gawin Signed-off-by: Mateusz Palczewski Tested-by: Dave Switzer Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index b519e5af5ed9..502b4abc0aab 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -1406,7 +1406,8 @@ static int i40e_set_fec_cfg(struct net_device *netdev, u8 fec_cfg) memset(&config, 0, sizeof(config)); config.phy_type = abilities.phy_type; - config.abilities = abilities.abilities; + config.abilities = abilities.abilities | + I40E_AQ_PHY_ENABLE_ATOMIC_LINK; config.phy_type_ext = abilities.phy_type_ext; config.link_speed = abilities.link_speed; config.eee_capability = abilities.eee_capability; -- 2.30.2