Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp435086pxj; Tue, 18 May 2021 06:44:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZnTIhhPAis6G6keuQwkJ+hcIowlOhStLYuKP/svfiwWbzr0D4xIDn25H/7wW5OWV2pJsx X-Received: by 2002:a92:2a12:: with SMTP id r18mr4392739ile.170.1621345474412; Tue, 18 May 2021 06:44:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621345474; cv=none; d=google.com; s=arc-20160816; b=N1fGtys3zCCw92npuKX5J2ASew6+fKaB1vur2btewbTmTR4ZC6eXcBTJD7Smh0XSur 0BVICqxBeGUI5tunJDajsiFw20g4JUBvQUMxFKpntggjm/yCKdDny4C++M3fe0P/70Ly mVZ1iIkVeyOPwFjQup26WHChvRUVyyZY+uwN8hCqilFIQbljNW+r1mmMoVtTEEU4NDtM 2XmEdZHc+WEiDLMgmFY5qqf6xmJLNwa2Yqbu+5/Fr1QMcWJ33mSQN92WfASBMpITXbf4 uETUkvbFrrnBdl34d7+gb2jW1shntm+XTyT/D6Y930B2AFuS1hImirStLu+BrNVUnnsz GNSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pf+80F/C9AN8IhC5jLmHc8LgVYKG89fxLnkR75WuhUs=; b=RmYWQ51yoDXMgtqkgvnbUPYCP5vOSbO1eIn/DPYTlF0yej1zdBN+VbDmhuw3HC6sIC 9HHLXg/hsMiRZol7C9V4ESEH3+lVamPz3wGfV3rSco3lspAZfG+egRGLXiDqhqpa6h9P 25shH8AIODRLHZNLODtABxvka6XoFrb3aNl11YJGQwXlE5wHfRJZsRZyE8ik8KyyEWKL pYk3LVUoZmKLs/wjmAKwmRNY8zH1UzMlAeKEX0kxcV5rrf393utJTC5IGF82d64+sJse kQsLoxjXnNna+kMiVUgz6rAikgp343VPLc1M9m0jGwm+RSIBu+lGFA527ymUWDRUQ4q3 /Vgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DiDbsyWv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k7si21320945ilo.146.2021.05.18.06.44.21; Tue, 18 May 2021 06:44:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DiDbsyWv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343872AbhEQPj4 (ORCPT + 99 others); Mon, 17 May 2021 11:39:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:41292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245093AbhEQPYg (ORCPT ); Mon, 17 May 2021 11:24:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BB96D61CA8; Mon, 17 May 2021 14:35:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621262147; bh=x6K84QG3HR9iITJc6J1QC6FonyXIiybpclJ9Qed+jzA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DiDbsyWvG7sCKwR8/ylHhIIN1aX+erDQQRLAZacshssBvyd7J/Bmdb6z86BDkinmw 8+U7uv332TA5Odk+Qelb3H1Iz5yx16ncj8KfuI5af0drS6nWAOqVFrEj7NmnqKgShy rm+lLcfGrxIb/ZSwdf/6hvitGJ99YzSPSUNt+0qo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jaroslaw Gawin , Mateusz Palczewski , Dave Switzer , Tony Nguyen , Sasha Levin Subject: [PATCH 5.11 226/329] i40e: fix the restart auto-negotiation after FEC modified Date: Mon, 17 May 2021 16:02:17 +0200 Message-Id: <20210517140309.767782482@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517140302.043055203@linuxfoundation.org> References: <20210517140302.043055203@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jaroslaw Gawin [ Upstream commit 61343e6da7810de81d6b826698946ae4f9070819 ] When FEC mode was changed the link didn't know it because the link was not reset and new parameters were not negotiated. Set a flag 'I40E_AQ_PHY_ENABLE_ATOMIC_LINK' in 'abilities' to restart the link and make it run with the new settings. Fixes: 1d96340196f1 ("i40e: Add support FEC configuration for Fortville 25G") Signed-off-by: Jaroslaw Gawin Signed-off-by: Mateusz Palczewski Tested-by: Dave Switzer Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index 31d48a85cfaf..13554706c180 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -1409,7 +1409,8 @@ static int i40e_set_fec_cfg(struct net_device *netdev, u8 fec_cfg) memset(&config, 0, sizeof(config)); config.phy_type = abilities.phy_type; - config.abilities = abilities.abilities; + config.abilities = abilities.abilities | + I40E_AQ_PHY_ENABLE_ATOMIC_LINK; config.phy_type_ext = abilities.phy_type_ext; config.link_speed = abilities.link_speed; config.eee_capability = abilities.eee_capability; -- 2.30.2