Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp505359pxj; Tue, 18 May 2021 08:11:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzHEqWyCCErgyet6E3GFXQcd2nR8xS7830CG48MA8gTVd1Ul3/XHOPuTvOCzH4LbQ+SDcU X-Received: by 2002:aa7:dc0b:: with SMTP id b11mr7769683edu.124.1621350702869; Tue, 18 May 2021 08:11:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621350702; cv=none; d=google.com; s=arc-20160816; b=z9QIowQmQos9hBCVMyj25aBXjNQ/d2x3JdMZvokJbCzK2DECyJn79zy1LXIh7O+AXP PfNEYkZYrN3iuts/0b1t6M0fF5xxJMK+wcMW5xL7DuT7RMS5wrqo/n5NQvureHwhEvOa kBeH/0GvopRLp1eiZgNPnMMI47/GIhb0yJ1BpgvVF+azYP+NR5b1oQAuMN1vuFTyCrUz IzmzDGS+WNWbhVHkXrK7441GOB/8lp7ySOjxQBAbtlcerJwv/xkh6H49fRonWFyQ+FkI q9AmHRn9pzYBR+wuUQyKmrH82kYfxQHtRBPvTh8IyWWib4q0HJ3vQlQiRS/3yyiyBuEV C4kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=D2oIH8i6fcrpo5rT5N0cPAQ5dNcZaNbFhXzGcodDI5U=; b=FFyiWErDPyanYUxAMu0GOHPFeYbxw99PAO7aLyduXG9dATIvwZWwHDTimARVR3Q9zq Aul2QST0Dmh5B+baPbRb36yKIVQ5c0X1H/ELlmx8Aw/w84WhM45CjCb7fYD9+r5bZipO 9PRuUKFF/lWdL463eD+XfNcvQsadlINESuv7Tp2vmAFCWNl8V3WxKQxEEaKnp98NOGRr F1gZXbZ1vduuAZQjAHrEN7iw1CuwD6aouWsc+vOG2O/ZKZdPAZp8/A/x4BdHRpwENL3G 3Oxj/UUKwxobBEHUONVjlgL0dzOIZH8qemnP1NBa25XF+wg91O4v5W4PtgHidEer6RCr UztA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="lVxPsT/d"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cr15si4491267ejc.676.2021.05.18.08.11.18; Tue, 18 May 2021 08:11:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="lVxPsT/d"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344497AbhEQPyN (ORCPT + 99 others); Mon, 17 May 2021 11:54:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:39362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241256AbhEQPgK (ORCPT ); Mon, 17 May 2021 11:36:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 084F261CF2; Mon, 17 May 2021 14:39:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621262400; bh=M8RgQpG2b4ai5zpHDappdZ5NZAFlHdCK45JXNfJIUtw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lVxPsT/dR4qMu4OMHYEnqI7a85UAWRtcWSunbU2UIfGLubrivzy+aQ/vcwPzR4V7n bCNmKkO5E5OPBpgkxjrauX7V3yDXWnunReimJLPiF8O+QRxB/Epavo6l6LWoep2cS1 Wgz7/q/zGV/Sn/KYIp2EXatQz8uSC4pkcSdq94co= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Maximilian Luz , Mathias Nyman Subject: [PATCH 5.11 283/329] usb: xhci: Increase timeout for HC halt Date: Mon, 17 May 2021 16:03:14 +0200 Message-Id: <20210517140311.675797341@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517140302.043055203@linuxfoundation.org> References: <20210517140302.043055203@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maximilian Luz commit ca09b1bea63ab83f4cca3a2ae8bc4f597ec28851 upstream. On some devices (specifically the SC8180x based Surface Pro X with QCOM04A6) HC halt / xhci_halt() times out during boot. Manually binding the xhci-hcd driver at some point later does not exhibit this behavior. To work around this, double XHCI_MAX_HALT_USEC, which also resolves this issue. Cc: Signed-off-by: Maximilian Luz Signed-off-by: Mathias Nyman Link: https://lore.kernel.org/r/20210512080816.866037-5-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/xhci-ext-caps.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/usb/host/xhci-ext-caps.h +++ b/drivers/usb/host/xhci-ext-caps.h @@ -7,8 +7,9 @@ * Author: Sarah Sharp * Some code borrowed from the Linux EHCI driver. */ -/* Up to 16 ms to halt an HC */ -#define XHCI_MAX_HALT_USEC (16*1000) + +/* HC should halt within 16 ms, but use 32 ms as some hosts take longer */ +#define XHCI_MAX_HALT_USEC (32 * 1000) /* HC not running - set to 1 when run/stop bit is cleared. */ #define XHCI_STS_HALT (1<<0)