Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp545374pxj; Tue, 18 May 2021 08:59:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNR7zlJSCnII9FWL1c2dkdoCLEx4spoaY4bvuBoch52gJMxB5gBJYLEy8fljwFEh0C9uQa X-Received: by 2002:a17:906:17cc:: with SMTP id u12mr6662145eje.170.1621353574931; Tue, 18 May 2021 08:59:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621353574; cv=none; d=google.com; s=arc-20160816; b=H3DG+yCwQZuG0vEPWYif/cVsklQt7a1TkfUpNx0coR+U6VCaIzTgymmjKTUz0oq2sU Zus1i52MY91LXjCK8yU9HyLj+WlHENGV6+CK6H0+d3O2wzrT6+ATxcu72nk5KAlXv2Rx BZXWlc620chTbhd6rJPkNyTcXT53NeLlGSml08o784/0teB7XyIh1LFjWZIvHlg8JTnw nn0j/9DijHKL+WHl6EzVlRfyoADdB7ArcisS2TfJ1reQ8Xqe/v/bowvFk7aX1BY6o/9T fItGSZXrDWDioifCrJXI7wJzq1gASwMBhlicWni3JnjpNGsbgu8gXR0h9/0dW65f6aVG faeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pf+80F/C9AN8IhC5jLmHc8LgVYKG89fxLnkR75WuhUs=; b=f7YFC1pKZcJVbRkEXzHrAD/caaarunNiBgDCyJk6uxfCGZw4Lo9L/VA20KVqlsej0J ipnQPGXcxeazVzX6OrDgrCG4fhW6mm5AVK5AX5iTesjMtV6YKCwWjHjt27xCRciOvu8t kTq5FhVRV8Kk9BtDmjmoG7Mr4sOdORfTcmlj/d30lckg0+x3JsJSfzl86Fv8RRjrFExl aHvYljz1WHiyLdc7an4VZYNIQq2jeilCSKHg/PfeHPSo8IxBi7Oshr5+Dho9xpPh4KNH u9vXXpiegOB9jWu0lziJHxUcIDFc20PEeg/cL9QQATES+KOzmBUhFQ3S8JsfdZ33wppo uXKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PIw7mVSu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kl9si17869196ejc.271.2021.05.18.08.58.45; Tue, 18 May 2021 08:59:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PIw7mVSu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345892AbhEQP5e (ORCPT + 99 others); Mon, 17 May 2021 11:57:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:40230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244510AbhEQPio (ORCPT ); Mon, 17 May 2021 11:38:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6639D61CF9; Mon, 17 May 2021 14:40:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621262450; bh=x6K84QG3HR9iITJc6J1QC6FonyXIiybpclJ9Qed+jzA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PIw7mVSuPRZ3ekS1NmN+eZCcLVVAwioVABnYjlmieeL0osCfg+8KCqj75Wf0+zdLs uOWfzvCjzCo5N9lHOHCK0mRuPBfBNB4k7xSyJ9CF4SY6StlEuMKsqOzStTeWq8if61 VwTLJ6jGIFoh6o7KEzuRik9VcfpTUymBRLLOI29U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jaroslaw Gawin , Mateusz Palczewski , Dave Switzer , Tony Nguyen , Sasha Levin Subject: [PATCH 5.10 190/289] i40e: fix the restart auto-negotiation after FEC modified Date: Mon, 17 May 2021 16:01:55 +0200 Message-Id: <20210517140311.507682527@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517140305.140529752@linuxfoundation.org> References: <20210517140305.140529752@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jaroslaw Gawin [ Upstream commit 61343e6da7810de81d6b826698946ae4f9070819 ] When FEC mode was changed the link didn't know it because the link was not reset and new parameters were not negotiated. Set a flag 'I40E_AQ_PHY_ENABLE_ATOMIC_LINK' in 'abilities' to restart the link and make it run with the new settings. Fixes: 1d96340196f1 ("i40e: Add support FEC configuration for Fortville 25G") Signed-off-by: Jaroslaw Gawin Signed-off-by: Mateusz Palczewski Tested-by: Dave Switzer Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index 31d48a85cfaf..13554706c180 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -1409,7 +1409,8 @@ static int i40e_set_fec_cfg(struct net_device *netdev, u8 fec_cfg) memset(&config, 0, sizeof(config)); config.phy_type = abilities.phy_type; - config.abilities = abilities.abilities; + config.abilities = abilities.abilities | + I40E_AQ_PHY_ENABLE_ATOMIC_LINK; config.phy_type_ext = abilities.phy_type_ext; config.link_speed = abilities.link_speed; config.eee_capability = abilities.eee_capability; -- 2.30.2