Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp545466pxj; Tue, 18 May 2021 08:59:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYi+z2cES8iOn8b1mKJJVMJp9Hv0lL6M9OQ9DWZjHZIQRcgEJLJJCvDaCjI75f1cBNGBbw X-Received: by 2002:a05:6402:51c9:: with SMTP id r9mr7916039edd.94.1621353580632; Tue, 18 May 2021 08:59:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621353580; cv=none; d=google.com; s=arc-20160816; b=sem4czobcKCHNDCDRbEokzY0+bIiJaXMz+Qf/g8Fs1RfykGbDBERpzlm8E+JpbHKH2 kHgXCywjSRWkTHm5WRMCWHtq8PefelNtb/vIIXhdC2oF//ZSYpEQOXzA3/t6gTm5FQBg JJjWCNxXLZ/HvNOIW5SxaEOrzlm2D1HQ9jshAqPkhL9VTdAjVbpGwgKNIdYskfHJ1njI BC4WsBs68hlrefpZVKQdCKVicmiO2IUXwIjpGNYgl2czayyVNDn6KfCmlWobIUJRZE8a m3b5twlWP1btb/Z+sSn1JdbS8Qj9c67KIzUkCE2nrqJNyob18YIVtTSJuHsy78hhz7Zo VGzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5cJODwyxkjpkHvYZjEDrOPa1AXJk64DPbUYHdHKKQ2Y=; b=myBaF0Cu4VMXnLD2WhSBMWG3zk2eqJbhLr22mxWF8+3cyASMQPlgVkiNBjGNhnfiIO iGVH3ZM/xqCEJBU4Xj2P4BlrgfcpJJ6ptyueojCGfkLAuVDTZTH/sHMx3Z/gdTMSVn7m mj30AlFtOPMm+KdVMlFyqIz6ODEgTBfIox32J3FZhspnrioSrQRafH/d0Z6mkU39eab1 MD6EEokbhhueR38STpoP+PxZi3UuRrfso2yDKAKMrUmNBxpGqno9hRpP7LlfK2HyonqG RFiS+uvZonGWEfOPa9x92iNYfXRBh5FRpXb9iGX60dvcsceFSA+Gquz/GSs8VLeK5Dom qTeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1nOeHgcV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p2si18524557ejb.4.2021.05.18.08.59.16; Tue, 18 May 2021 08:59:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1nOeHgcV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240004AbhEQP6a (ORCPT + 99 others); Mon, 17 May 2021 11:58:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:50648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245521AbhEQPjL (ORCPT ); Mon, 17 May 2021 11:39:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 18DCC61CFE; Mon, 17 May 2021 14:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621262477; bh=TZev9StsWgHu4WF6G+FIHP5tmHQKm6mneARLeqjVLIw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1nOeHgcV8V21IpkGmfnbLRSpVSv7eBcUL8OUR3+/utnSKK7uOWXqxr7slowoIgxji x8arsj1ebdcs9cSPOkIvbelRRTg8Nqjkq9ncrjPKD0ItgzjTlGAxzoVXkVPg4IwkIy d4EJwg4se7YFn3CYzbPwNjksqYp+78sWQUMugE7I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sean Christopherson , Jim Mattson , Paolo Bonzini Subject: [PATCH 5.11 299/329] KVM: x86: Move RDPID emulation intercept to its own enum Date: Mon, 17 May 2021 16:03:30 +0200 Message-Id: <20210517140312.207282886@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517140302.043055203@linuxfoundation.org> References: <20210517140302.043055203@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Christopherson commit 2183de4161b90bd3851ccd3910c87b2c9adfc6ed upstream. Add a dedicated intercept enum for RDPID instead of piggybacking RDTSCP. Unlike VMX's ENABLE_RDTSCP, RDPID is not bound to SVM's RDTSCP intercept. Fixes: fb6d4d340e05 ("KVM: x86: emulate RDPID") Cc: stable@vger.kernel.org Signed-off-by: Sean Christopherson Message-Id: <20210504171734.1434054-5-seanjc@google.com> Reviewed-by: Jim Mattson Signed-off-by: Paolo Bonzini Signed-off-by: Greg Kroah-Hartman --- arch/x86/kvm/emulate.c | 2 +- arch/x86/kvm/kvm_emulate.h | 1 + arch/x86/kvm/vmx/vmx.c | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -4502,7 +4502,7 @@ static const struct opcode group8[] = { * from the register case of group9. */ static const struct gprefix pfx_0f_c7_7 = { - N, N, N, II(DstMem | ModRM | Op3264 | EmulateOnUD, em_rdpid, rdtscp), + N, N, N, II(DstMem | ModRM | Op3264 | EmulateOnUD, em_rdpid, rdpid), }; --- a/arch/x86/kvm/kvm_emulate.h +++ b/arch/x86/kvm/kvm_emulate.h @@ -468,6 +468,7 @@ enum x86_intercept { x86_intercept_clgi, x86_intercept_skinit, x86_intercept_rdtscp, + x86_intercept_rdpid, x86_intercept_icebp, x86_intercept_wbinvd, x86_intercept_monitor, --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -7346,8 +7346,9 @@ static int vmx_check_intercept(struct kv /* * RDPID causes #UD if disabled through secondary execution controls. * Because it is marked as EmulateOnUD, we need to intercept it here. + * Note, RDPID is hidden behind ENABLE_RDTSCP. */ - case x86_intercept_rdtscp: + case x86_intercept_rdpid: if (!nested_cpu_has2(vmcs12, SECONDARY_EXEC_ENABLE_RDTSCP)) { exception->vector = UD_VECTOR; exception->error_code_valid = false;