Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp597792pxj; Tue, 18 May 2021 09:58:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYYX3T4lFJdT7Y0nOHRqOzBER9smoMxrzXx7xLho5u2c4BnWm/7HSw7ME/GSevOXYaJaEJ X-Received: by 2002:a17:907:6289:: with SMTP id nd9mr6944296ejc.384.1621357091263; Tue, 18 May 2021 09:58:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621357091; cv=none; d=google.com; s=arc-20160816; b=Si3COTA6jvPHJ/GMAQYakzYNPdFd2WUEv3Zu36cLTmcO19GX8mPCJbovq9hLLWsWAN D6r+gC16w7aUlQzhgbh8mJNZ1aMhVyntEySOStWLi10w8qg9R5vvvsae4mu3LQ/83KDe df18tpA1Uoe4bTZTBBSqlDEa5OT9aMe1ZKMjXEbwvy9uWbsVA/kT8S/rwER+bHuYqjjv B1SnyGu4yFeXXiOxCwlasylhJjFaF19A9IJlofLb88S8ZZ6hb2p9HzqiL8cvE+Is3YR5 AQ5YelUnTlHnT4szzqhTW/K7kDl7rrU6Zj9MsLo5Cvw/6EnmBUCCWi1+5aI70IukpmnB 1jEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xsz+vGwRUxo0qPlFMYjycKErODu/8pRzdRcL630FiL0=; b=BRLTHfsLYz70FivKXCC8STgbqBXbfpR3hAOFyEX210tWqrIoKeUwvfuDq9yyViHbO0 sYdzGzaV+MSpT9CJCAMxRYh8taih5atf+vWee+JvCylFeE4ihpRogHm3dEhRbrOP6wem RFpyNbOnUU6m13HY+WF9VYdcW072GsvHxF8Y+Qapd+a0jD0yOmJCWcZspIeVkCHyhnWF uC4WsslqnvZhVKar3EDkHC4ZbMRB0ZmzSULiU6Saa4lJ++klJheINmMJXCqhgUGGzFP7 qgc7n4nrkBnh488v39X436fuKGpenrA1fvcEuwr/EPEHv0/tVuBkiWv1oDgQEjykOvLE i9XA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zrRT4HdD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h21si17240582ejt.566.2021.05.18.09.57.29; Tue, 18 May 2021 09:58:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zrRT4HdD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346160AbhEQQEn (ORCPT + 99 others); Mon, 17 May 2021 12:04:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:52118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242762AbhEQPoC (ORCPT ); Mon, 17 May 2021 11:44:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2CCA261950; Mon, 17 May 2021 14:43:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621262586; bh=eFLFcCVjj/Juat7SVA7Sv9+IO9Wv0EhmVYpN/GkN9u4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zrRT4HdDsZRJsn1h/fWd7RhOMJOTBQeQbf3967wkvqg1SdKtW89Yy5ajjT8cnhGSa yO2gS17Kw+YBlpt2NVCkS5OwFR63fwwluY/lUPoCsXs8iUxRav8Mtc8Mjd00BC+wSA GE6b6lhk8HIQyapLTMdF0SzLVFLjJ4iWHjOtvZ1Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Peter Enderborg , Kees Cook Subject: [PATCH 5.11 326/329] debugfs: Make debugfs_allow RO after init Date: Mon, 17 May 2021 16:03:57 +0200 Message-Id: <20210517140313.113166635@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517140302.043055203@linuxfoundation.org> References: <20210517140302.043055203@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kees Cook commit 312723a0b34d6d110aa4427a982536bb36ab8471 upstream. Since debugfs_allow is only set at boot time during __init, make it read-only after being set. Fixes: a24c6f7bc923 ("debugfs: Add access restriction option") Cc: Peter Enderborg Reviewed-by: Peter Enderborg Signed-off-by: Kees Cook Link: https://lore.kernel.org/r/20210405213959.3079432-1-keescook@chromium.org Signed-off-by: Greg Kroah-Hartman --- fs/debugfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -35,7 +35,7 @@ static struct vfsmount *debugfs_mount; static int debugfs_mount_count; static bool debugfs_registered; -static unsigned int debugfs_allow = DEFAULT_DEBUGFS_ALLOW_BITS; +static unsigned int debugfs_allow __ro_after_init = DEFAULT_DEBUGFS_ALLOW_BITS; /* * Don't allow access attributes to be changed whilst the kernel is locked down