Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 17 May 2021 10:27:45 -0700
From:   Eric Biggers <ebiggers@kernel.org>
To:     Chao Yu <yuchao0@huawei.com>
Cc:     jaegeuk@kernel.org, marcosfrm <marcosfrm@gmail.com>,
        linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: add MODULE_SOFTDEP to ensure crc32c is
 included in the initramfs
Message-ID: <YKKnkSag35cDXh0Z@gmail.com>
References: <20210517011557.21722-1-yuchao0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210517011557.21722-1-yuchao0@huawei.com>
Precedence: bulk

On Mon, May 17, 2021 at 09:15:57AM +0800, Chao Yu wrote:
> As marcosfrm reported in bugzilla:
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=213089
> 
> Initramfs generators rely on "pre" softdeps (and "depends") to include
> additional required modules.
> 
> F2FS does not declare "pre: crc32" softdep. Then every generator (dracut,
> mkinitcpio...) has to maintain a hardcoded list for this purpose.
> 
> Hence let's use MODULE_SOFTDEP("pre: crc32") in f2fs code.
> 
> Fixes: 43b6573bac95 ("f2fs: use cryptoapi crc32 functions")
> Reported-by: marcosfrm <marcosfrm@gmail.com>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
>  fs/f2fs/super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 3f8a7a6c250c..fa0ce6301c16 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -4431,4 +4431,5 @@ module_exit(exit_f2fs_fs)
>  MODULE_AUTHOR("Samsung Electronics's Praesto Team");
>  MODULE_DESCRIPTION("Flash Friendly File System");
>  MODULE_LICENSE("GPL");
> +MODULE_SOFTDEP("pre: crc32c");

Shouldn't it be crc32, not crc32c?

- Eric