Received: by 2002:a05:6520:4211:b029:f4:110d:56bc with SMTP id o17csp723857lkv; Tue, 18 May 2021 18:22:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxp9VDupkq8lCG9qxRPQxRVsSJfccRNBXZyHEbEgvTpC7QZ/RF9lKLNuDjRp+BCimIurPPp X-Received: by 2002:a5e:c742:: with SMTP id g2mr1195643iop.40.1621387331252; Tue, 18 May 2021 18:22:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621387331; cv=none; d=google.com; s=arc-20160816; b=vzPkOtDUFLoKLukMUTGlbXPfaX1hF/Hn/u9CcYHtMgqlxZqVBHuB5yJwEny96DboP6 nabHfgbZVsNRQ2WCANTkcEX3GyzYKn1FefK5kFtrxsNc+qr5Ccfv8bnMpb5pRqa/JFfq qipws15zqAjefaHzxAcQbmmamt4hEtrkMNOODucH4BFalfxqz33qzTIKVgw7iZZP646Y 9iElubb76sCwj9UhFTbI+Ew48fIGue7mtJb7jJ3n+RO08KYEp+LF28iI+LtxjpBr1DoH UGSqP1Hmt7vLNBx4T6j1aOmGvAbzvMPKDrH73M+YhdpWHswMZy0VUprMew6oz84epZOk NJpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=RgO5PZp5sg1uOBfz6Mo0I/T1+iA05mzESFPtCNaQU/M=; b=seLwHPe4KPQP/69PnDq5+LVEtHtLLWFYWQwbPWFvRFnGFp/XjMciBBf9TeMndSDK1e y3/aGpiqlNIJ3DFvgUmgIVCBfbtUnwT5elnvVQlEm+GPD54yyGNmu355BsMQoWKJKZqk b8nCzN/UjE69FxgYl6lsNib3a+6WD9dbVLBS18Brvrb2bXwPkw+ZdisIRaS+07T7ZQ0L 0GpiWSE200SlVRHULUWkeq2jbXjLuFzFuwpOwvvMsZFb98gnbtq0K+KBahdw5GRoKsBU ZqWGf9j70Tnkn/7D7X+xxZ8F14LSf0SLVVMUNkO7HmQ1TxNz9BvvhyUMjmSfeAelqK4/ kErg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dzqv6P4+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si10781988jad.109.2021.05.18.18.21.59; Tue, 18 May 2021 18:22:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dzqv6P4+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233221AbhEQTY5 (ORCPT + 99 others); Mon, 17 May 2021 15:24:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232775AbhEQTY5 (ORCPT ); Mon, 17 May 2021 15:24:57 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 929AFC061573; Mon, 17 May 2021 12:23:39 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id u19-20020a0568302493b02902d61b0d29adso6528296ots.10; Mon, 17 May 2021 12:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RgO5PZp5sg1uOBfz6Mo0I/T1+iA05mzESFPtCNaQU/M=; b=dzqv6P4+T6AJsl2STE/YPGX+AwgvEtOpPIi/7MmlW7CKBSYhMK2cjZFM7HP6aZSo5A vXutRcoufTlpPu9v3aI3Uj7u+KXVnsyhSsbMjQeSnlY1cXAbKnUfdwDulJC+CjEFyKSG 4p8skbHH/R3nZk7SKOKX6K+iHbSFnhOeZvCwnajObAUGMwgjB40l6RayQY0tQwaNxiLI VqgfsrINYcegnyCm4Dvru2/Yxi+C+jYpXgXnd+yA9O4boacGpteapRqdLHpyHEokSo6V 6K19loSQQRjjq788k4ttQEywq58rwd2Yg6RF6y23fIPxpu3/NLq9BLS/A4jpc4eJMvNY bpIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RgO5PZp5sg1uOBfz6Mo0I/T1+iA05mzESFPtCNaQU/M=; b=RIMWZhuhgJkXUWoSGv8fVlnqfCWk8/CkKQ1YoYjjtKqNJOmvAiyNrLP+SEl8J0CsOs V7HOgMdmO/zfA3FmdpZF+1K9ZhONmvgoZE12Y+pEF3c/MDTAIVrmd3jXRmClHFLyVvKw bce6pAKgRYVVdhgZaf847vzExqSKwhMeVTKwclmvdWqL931JLUqjrNDWZlR0RNmJiIgK b43QpDIymRDcfrXqcfC70e6AHPWYGpvRGTdgimPwRpBRSsiqPmvq2Eicrre1jq9jfP/3 nSWt+0QHL/dgyNGT3tN7M8fculyrHHpV25aR1wxicF5YIB506wgTrvDPQYtebD33K5cz CKww== X-Gm-Message-State: AOAM530/2mw5G5ue5Y7z9sZXGtfZbB6IwiZyoFDyLoL/YQlRNzZngUxJ qXwMqtwdF/P+35ByUfG/nUbcyLknoP/M2goznRc= X-Received: by 2002:a9d:74c6:: with SMTP id a6mr971495otl.132.1621279418884; Mon, 17 May 2021 12:23:38 -0700 (PDT) MIME-Version: 1.0 References: <20210513110040.2268-1-maciej.kwapulinski@linux.intel.com> <503d101d-7273-757a-2809-e272db93c45d@suse.de> In-Reply-To: <503d101d-7273-757a-2809-e272db93c45d@suse.de> From: Alex Deucher Date: Mon, 17 May 2021 15:23:27 -0400 Message-ID: Subject: Re: [PATCH v3 00/14] Driver of Intel(R) Gaussian & Neural Accelerator To: Thomas Zimmermann Cc: Arnd Bergmann , Dave Airlie , Greg Kroah-Hartman , Maciej Kwapulinski , Jonathan Corbet , Derek Kiernan , Dragan Cvetic , Andy Shevchenko , Linux Kernel Mailing List , "open list:DOCUMENTATION" , DRI Development Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 17, 2021 at 3:12 PM Thomas Zimmermann wro= te: > > Hi > > Am 17.05.21 um 09:40 schrieb Daniel Vetter: > > On Fri, May 14, 2021 at 11:00:38AM +0200, Arnd Bergmann wrote: > >> On Fri, May 14, 2021 at 10:34 AM Greg Kroah-Hartman > >> wrote: > >>> On Thu, May 13, 2021 at 01:00:26PM +0200, Maciej Kwapulinski wrote: > >>>> Dear kernel maintainers, > >>>> > >>>> This submission is a kernel driver to support Intel(R) Gaussian & Ne= ural > >>>> Accelerator (Intel(R) GNA). Intel(R) GNA is a PCI-based neural co-pr= ocessor > >>>> available on multiple Intel platforms. AI developers and users can o= ffload > >>>> continuous inference workloads to an Intel(R) GNA device in order to > free > >>>> processor resources and save power. Noise reduction and speech recog= nition > >>>> are the examples of the workloads Intel(R) GNA deals with while its = usage > >>>> is not limited to the two. > >>> > >>> How does this compare with the "nnpi" driver being proposed here: > >>> https://lore.kernel.org/r/20210513085725.45528-1-guy.zadicar= io@intel.com > >>> > >>> Please work with those developers to share code and userspace api and > >>> tools. Having the community review two totally different apis and > >>> drivers for the same type of functionality from the same company is > >>> totally wasteful of our time and energy. > >> > >> Agreed, but I think we should go further than this and work towards a > >> subsystem across companies for machine learning and neural networks > >> accelerators for both inferencing and training. > > > > We have, it's called drivers/gpu. Feel free to rename to drivers/xpu or > > think G as in General, not Graphisc. > > I hope this was a joke. > > Just some thoughts: > > AFAICT AI first came as an application of GPUs, but has now > evolved/specialized into something of its own. I can imagine sharing > some code among the various subsystems, say GEM/TTM internals for memory > management. Besides that there's probably little that can be shared in > the userspace interfaces. A GPU is device that puts an image onto the > screen and an AI accelerator isn't. Treating both as the same, even if > they share similar chip architectures, seems like a stretch. They might > evolve in different directions and fit less and less under the same > umbrella. The putting something on the screen is just a tiny part of what GPUs do these days. Many GPUs don't even have display hardware anymore. Even with drawing APIs, it's just some operation that you do with memory. The display may be another device entirely. GPUs also do video encode and decode, jpeg acceleration, etc. drivers/gpu seems like a logical place to me. Call it drivers/accelerators if you like. Other than modesetting most of the shared infrastructure in drivers/gpu is around memory management and synchronization which are all the hard parts. Better to try and share that than to reinvent that in some other subsystem. Alex > > And as Dave mentioned, these devices are hard to obtain. We don't really > know what we sign up for. > > Just my 2 cents. > > Best regards > Thomas > > > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > (HRB 36809, AG N=C3=BCrnberg) > Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer >