Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752497AbWJ0Vbl (ORCPT ); Fri, 27 Oct 2006 17:31:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752498AbWJ0Vbl (ORCPT ); Fri, 27 Oct 2006 17:31:41 -0400 Received: from gw.goop.org ([64.81.55.164]:7902 "EHLO mail.goop.org") by vger.kernel.org with ESMTP id S1752497AbWJ0Vbk (ORCPT ); Fri, 27 Oct 2006 17:31:40 -0400 Message-ID: <45427ABD.6070407@goop.org> Date: Fri, 27 Oct 2006 14:31:41 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 1.5.0.7 (X11/20061008) MIME-Version: 1.0 To: Pavel Machek CC: Rusty Russell , Andrew Morton , virtualization , lkml - Kernel Mailing List Subject: Re: [PATCH 1/4] Prep for paravirt: Be careful about touching BIOS address space References: <1161920325.17807.29.camel@localhost.localdomain> <1161920535.17807.33.camel@localhost.localdomain> <20061027113001.GB8095@elf.ucw.cz> In-Reply-To: <20061027113001.GB8095@elf.ucw.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 22 Pavel Machek wrote: > Indentation is b0rken here. > Oops. How strange. > And... is get_user right primitive for accessing area that may not be > there? I'm pretty sure there's precedent for using __get_user in this way (get_user is a different matter, since it cares about whether the address is within the user part of the address space). Certainly in arch/i386 code there shouldn't be a problem. Is there some other way to achieve the same effect (without manually setting up an exception/fixup block)? J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/